teach deploy-uni-hook the fleet audit rules - #992
Merged
Conversation
The aeon-vuln/onchain audits found a shared exact-output fee skip, custody take() to address(this), int128.min abs panic, and a standing gate checklist (off-by-one, contention DoS, raw amountSpecified cap). The skim template still had the first two. Patch it, fail custody in the static scan, and put the checklist in the generator so freeform does not recreate them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
aeon-vuln
memory/topics/aeon-fun-hooks.mdand aeon-onchain coverage already measured these on the live fleet. Canondeploy-uni-hookstill shipped them:skimskipped the fee on exact-output (unspecifiedAmount <= 0)skimtake()d toaddress(this)and neededwithdraw()(custody HIGH)What
HookFeeHook: charge magnitude (exact-in and exact-out), widen to int256 before abs,take()to immutablefeeRecipient, no withdrawtake(..., address(this), ...); WARN exact-out skip andbalanceOf(poolManager)Follow-up of #991 (Labs routing). Does not change catalogs.
Test
bash -n skills/deploy-uni-hook/hook-deploy.shconstructor(IPoolManager)so DeployHook.s.sol is unchanged