Skip to content

Adds support for overriding vfuncs to InteropGenerator. #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
universalconquistador wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −3
Open

Adds support for overriding vfuncs to InteropGenerator. #1943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions InteropGenerator/Generator/InteropGenerator.Rendering.Inheritance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ private static void RenderInheritance(StructInfo structInfo, ImmutableArray<Stru
// inherited virtual function bodies
foreach ((StructInfo inheritedStruct, string path, int offset) in resolvedInheritanceOrder) {
if (!inheritedStruct.VirtualFunctions.IsEmpty)
RenderInheritedVirtualFunctions(structInfo.Name, inheritedStruct, path, offset, writer);
RenderInheritedVirtualFunctions(structInfo, inheritedStruct, path, offset, writer);
}

token.ThrowIfCancellationRequested();
Expand Down Expand Up @@ -199,12 +199,21 @@ private static void RenderInheritedVirtualTable(StructInfo structInfo, Immutable
if (!structInfo.HasVirtualTable())
writer.WriteLine("[global::System.Runtime.InteropServices.StructLayoutAttribute(global::System.Runtime.InteropServices.LayoutKind.Explicit)]");
writer.WriteLine($"public unsafe partial struct {structInfo.Name}VirtualTable");
HashSet<uint> presentVfuncOffsets = new();
foreach (var vfunc in structInfo.VirtualFunctions) {
presentVfuncOffsets.Add(vfunc.Index);
}
using (writer.WriteBlock()) {
foreach ((StructInfo inheritedStruct, _, int offset) in resolvedInheritanceOrder) {
// only inherited structs at offset 0 are the primary inheritance chain that make up the main virtual table
if (offset != 0)
continue;
foreach (VirtualFunctionInfo virtualFunctionInfo in inheritedStruct.VirtualFunctions) {
// if the inherited vfunc has been redefined, skip it
if (presentVfuncOffsets.Contains(virtualFunctionInfo.Index))
continue;
else
presentVfuncOffsets.Add(virtualFunctionInfo.Index);
var functionPointerType = $"delegate* unmanaged <{structInfo.Name}*, {virtualFunctionInfo.MethodInfo.GetParameterTypeStringWithTrailingTypeNoGenerics()}{virtualFunctionInfo.MethodInfo.ReturnTypeOrVoid}>";
foreach (string inheritedAttribute in virtualFunctionInfo.MethodInfo.InheritableAttributes)
writer.WriteLine(inheritedAttribute);
Expand All @@ -219,21 +228,39 @@ private static void RenderInheritedVirtualTable(StructInfo structInfo, Immutable
}

private static void RenderInheritedDelegateTypes(StructInfo structInfo, ImmutableArray<(StructInfo inheritedStruct, string path, int offset)> resolvedInheritanceOrder, IndentedTextWriter writer) {
HashSet<uint> presentVfuncOffsets = new();
foreach (var vfunc in structInfo.VirtualFunctions) {
presentVfuncOffsets.Add(vfunc.Index);
}
writer.WriteLine("public static partial class Delegates");
using (writer.WriteBlock()) {
foreach ((StructInfo inheritedStruct, _, int offset) in resolvedInheritanceOrder) {
// only inherited structs at offset 0 are the primary inheritance chain that make up the main virtual table
if (offset != 0)
continue;
foreach (VirtualFunctionInfo virtualFunctionInfo in inheritedStruct.VirtualFunctions) {
// if the inherited vfunc has been redefined, skip it
if (presentVfuncOffsets.Contains(virtualFunctionInfo.Index))
continue;
else
presentVfuncOffsets.Add(virtualFunctionInfo.Index);
RenderDelegateTypeForMethod(structInfo.Name, virtualFunctionInfo.MethodInfo, writer);
}
}
}
}

private static void RenderInheritedVirtualFunctions(string childTypeName, StructInfo inheritedStruct, string path, int offset, IndentedTextWriter writer) {
private static void RenderInheritedVirtualFunctions(StructInfo structInfo, StructInfo inheritedStruct, string path, int offset, IndentedTextWriter writer) {
HashSet<uint> presentVfuncOffsets = new();
foreach (var vfunc in structInfo.VirtualFunctions) {
presentVfuncOffsets.Add(vfunc.Index);
}
foreach (VirtualFunctionInfo virtualFunctionInfo in inheritedStruct.VirtualFunctions) {
// if the inherited vfunc has been redefined, skip it
if (presentVfuncOffsets.Contains(virtualFunctionInfo.Index))
continue;
else
presentVfuncOffsets.Add(virtualFunctionInfo.Index);
MethodInfo methodInfo = virtualFunctionInfo.MethodInfo;
if (offset != 0 && methodInfo.Name == "Dtor") continue;
writer.WriteLine($"""/// <inheritdoc cref="{inheritedStruct.FullyQualifiedMetadataName}.{methodInfo.NameXmlEscaped}({methodInfo.GetParameterTypeStringForCref()})" />""");
Expand All @@ -247,7 +274,7 @@ private static void RenderInheritedVirtualFunctions(string childTypeName, Struct
var paramNames = string.Empty;
if (methodInfo.Parameters.Any())
paramNames = ", " + methodInfo.GetParameterNamesString();
writer.WriteLine($"{methodInfo.GetDeclarationStringWithoutPartial()} => {virtualFunctionInfo.MethodInfo.ReturnTypeCast}VirtualTable->{methodInfo.NameNonGeneric}(({childTypeName}*)global::System.Runtime.CompilerServices.Unsafe.AsPointer(ref this){paramNames});");
writer.WriteLine($"{methodInfo.GetDeclarationStringWithoutPartial()} => {virtualFunctionInfo.MethodInfo.ReturnTypeCast}VirtualTable->{methodInfo.NameNonGeneric}(({structInfo.Name}*)global::System.Runtime.CompilerServices.Unsafe.AsPointer(ref this){paramNames});");
} else {
writer.WriteLine($"{methodInfo.GetDeclarationStringWithoutPartial()} => {path}.{methodInfo.Name}({methodInfo.GetParameterNamesString()});");
}
Expand Down