Repository navigation
Fill in cran-comments.md test environments - #7
Merged
Merged
Conversation
All five GitHub Actions platforms (ubuntu devel/release/oldrel-1, macOS release, windows release) have now passed repeatedly, so they can be listed honestly. The earlier TODO existed because the workflow had never run when the file was written; listing them then would have asserted results that did not exist. Also noted that the CI jobs use error_on = "warning", so a warning fails them as well as an error -- which is stricter than a plain --as-cran run and worth telling a reviewer. Recorded the one way the file does not currently match reality: while DESCRIPTION carries the .9000 development version, the incoming-feasibility note additionally reports "Version contains large components". That vanishes once a release version is set, which is the state the file describes, so the mismatch is expected rather than stale -- but it would be confusing to find later without explanation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All five GitHub Actions platforms (ubuntu devel/release/oldrel-1, macOS
release, windows release) have now passed repeatedly, so they can be listed
honestly. The earlier TODO existed because the workflow had never run when
the file was written; listing them then would have asserted results that
did not exist.
Also noted that the CI jobs use error_on = "warning", so a warning fails
them as well as an error -- which is stricter than a plain --as-cran run
and worth telling a reviewer.
Recorded the one way the file does not currently match reality: while
DESCRIPTION carries the .9000 development version, the
incoming-feasibility note additionally reports "Version contains large
components". That vanishes once a release version is set, which is the
state the file describes, so the mismatch is expected rather than stale --
but it would be confusing to find later without explanation.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com