Repository navigation
fix(drivers): Electron app window, first page load limit, no npx env in app commands - #213
Conversation
…ever driven An app that keeps a small always-on-top window open beside its main window, such as Nebula Desktop's Push to talk capsule, could have that window chosen as the app page: both are visible app pages, and on Linux the overlay can hold focus. Every replay of a review then captured the overlay. connect.window is a regex the main window's URL matches; only a matching page is driven and captured. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KXatHM4A5GhLuX4NoAaXYm
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugpatrol review: fixture-appNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
Bugpatrol review: dashboardNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ca4b300e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bugpatrol review: cliNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
npx sets npm_config_user_agent and other npm_ variables for Bugpatrol's own process, and every prepare, setup and verify command inherited them, so an only-allow guard in the app's preinstall saw npm and refused. Bugpatrol now drops them at startup, before it runs anything. Closes #210 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ow switch - connect.loadTimeoutMs sets how long a web app's first page load may take, for a dev server that builds the app on its first request (Metro for Expo web). A timeout is an infrastructure error that names the setting. - connect.window now also bounds the explorer's window action, so it cannot switch to the overlay the pattern leaves out. - connect.window resolves setup captures before it compiles, like the other connect strings. Closes #211 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…an invalid one as config A setup capture is a secret, and the no-page error printed the compiled pattern with the capture in it. A capture that made the pattern invalid threw a bare SyntaxError, read as an infrastructure failure; it is now a ConfigError naming app.connect.window. Docs scope loadTimeoutMs to the explorer, say the window pattern applies at connect and on a switch, and say every lowercase npm_ variable is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex (gpt-reserve, xhigh) and Muse reviewed Fixed in 02540d7:
Not changed, with reasons:
|
|
Merged as 2c57911. |
Three driver and launch fixes for apps Bugpatrol could not test.
connect.windowis a regex the app window's URL matches: page choice skips pages that don't match, the explorer'swindowaction cannot switch to one, and setup captures (${NAME}) resolve before the pattern compiles.page.gotolimit, and no setting reached it.connect.loadTimeoutMssets that first load's limit; a timeout is an infrastructure error naming the setting.npx bugpatrolsetsnpm_config_user_agentand othernpm_*variables for Bugpatrol's process, and every app command inherited them, so anonly-allowguard in the app'spreinstallsaw npm and refused. Bugpatrol dropsnpm_*at startup (dropLauncherEnvinpackages/cli/src/argv.ts), the one point before any command runs.Scope
Drivers (
web.ts,electron.ts,factory.ts), config schema, CLI entry, docs/configuration.md. Nothing in the request deny list.Verification
pnpm gateandpnpm gate:changed(biome, knip, tsc, vitest on changed files: 112 tests).connect.windowis a ConfigError without the capture; an overlay with focus beside the main window; a window action toward the excluded overlay is refused;connect.windowcaptures resolve in the factory; a slow first response loads withinloadTimeoutMsand fails past it with the setting named;dropLauncherEnvdropsnpm_*and keeps other variables.Reviews
Codex and Muse reviewed the diff and exchanged exclusive findings; outcomes are in the PR conversation. Fixed: captures kept out of the no-page error, an invalid substituted pattern is a ConfigError, docs scoped.
Risks
npm_*variables are gone for every command Bugpatrol runs, including a fixer'sverify. A package manager the app's command starts sets its own;.npmrcand uppercaseNPM_CONFIG_*still apply.loadTimeoutMsis unset by default, which keeps Playwright's 30 s.Closes #212
Closes #211
Closes #210
🤖 Generated with Claude Code