Repository navigation
Conversation
report_bug matched its error only against the console and network errors of the last observation. A web observation drains the errors it reports, so a look after the crash left that list empty and an error the explorer had just been shown was refused. The session now keeps every error it saw with the trail position, and a report checks against those seen since the start of its steps, which is what the replay of those steps sees. Closes #217 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A review killed mid-run (SIGKILL) left its report at status running with no way to tell it from a live one. The report now records the pid of the process that runs it, and the dashboard reader shows a running review whose process ended as failed and interrupted, as it already does for sessions. Closes #218 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugpatrol review: fixture-appNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9235f1b085
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ...(redactedObservation.networkErrors ?? []), | ||
| ]); | ||
| // The replay of the report's steps sees every error from the start of those steps. | ||
| const errors = session.errorsSeen.filter((seen) => seen.step >= session.anchor.index).map((seen) => seen.text); |
There was a problem hiding this comment.
Preserve errors from the newly saved anchor routine
When an action produces a console or network error and the explorer calls save_routine before report_bug, capture() records the error at the trail length before that action is appended, while saveRoutine() advances anchor.index to the length after it. This filter consequently drops the error and rejects the report, even though the candidate's routineId would replay the saved action and reproduce it, silently losing a valid finding.
AGENTS.md reference: AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Accepted, fixed in 7697fea. The session no longer filters errors by trail position. It keeps every error since the start of what a report replays, and clears them only where that replay starts over: run_routine, a claim flow, or a control change (new AgentSession.startFlow). save_routine continues the flow, since the saved routine holds the earlier steps. The test in agents-flow.test.ts now saves a routine between the error and the report (accepted), then starts a new flow (refused).
Bugpatrol review: dashboardNo problem introduced · tested
Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
Bugpatrol review: cliNo problem introduced · tested
Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
The error check filtered by trail position, but an action's error is recorded before the action joins the trail, and save_routine moves the anchor past it. A saved routine holds those steps, so its replay still sees the error. The session now clears its errors only where a report's replay starts over: a replayed routine, a claim flow or a control change (startFlow), and a report checks against all errors seen since. Refs #217 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A report checks its error against every error seen since its flow started, but a saved routine drops wait steps and detours. An error shown on such a step was accepted though the replayed routine never reproduces it. Each seen error now keeps the trail step that showed it, saveRoutine records the steps compactSteps leaves out, and report_bug accepts only errors on steps the replay still takes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed action adds no trail step, so its observation's errors are not part of any replay. Saving over the routine a flow continues replaces it, so errors from before the slice no longer replay. An error seen before a flow's first step (a routine replay) belongs to no old trail step. Saving now filters the seen errors to what the new routine replays instead of marking left-out steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review recordHead: 81e41d4 Codex (gpt-reserve, xhigh) review result and outcomes:
Fast checks: biome, tsc --build, vitest agents-flow.test.ts and api-evidence.test.ts pass. CI green at this head. Muse review not run: subscription quota exhausted until 2026-11-23T00:00:00Z (API error 429); a reviewer lost to quota is not replaced. |
Two fixes to how Bugpatrol reads what happened in a run.
flowchart LR A[look shows console error] --> B[next look drains it] B --> C{report_bug error} C -->|before: last observation only| D[refused] C -->|now: errors seen since the report's steps began| E[accepted]report_bug accepts an error an earlier look showed
report_bugchecked itserroronly against the console and network errors of the last observation. A web observation drains the errors it reports, so alookafter a crash returned an empty list and the explorer's error was refused even though it had just been shown. The session now keeps every error seen since the start of what a report replays, and a report checks its error against all of them. They are cleared only where that replay starts over: a replayed routine, a claim flow, or a change of control of the app (AgentSession.startFlow). Saving a routine continues the flow, since the routine holds the steps before it.A killed review no longer reads as running
A review stopped by SIGKILL left
pr-N.jsonatstatus: runningfor good. The review report now records thepidof its process, and the dashboard reader shows a running review whose process is gone asfailedwithInterrupted. Stopped: its process ended., matching how it already treats sessions. The next run of the review overwrites the record as before.Verification
pnpm gate:changed(biome, tsc, vitest for changed files): 41 files, 373 tests pass.agents-flow.test.ts(error shown, then a look and a saved routine, then a report with that error is accepted; after a new flow it is refused) anddashboard/src/agents.test.ts(running review with a dead pid reads as failed; a live pid stays running).review.test.tschecks the pid is recorded.Closes #217
Closes #218
🤖 Generated with Claude Code