Repository navigation
feat: show planned assignees in dry runs and record unprovisioned keys - #28
Conversation
issues sync --dry-run now carries the planned assignee on each create and edit action (JSON "assignee", text "-> HANDLE"), so owner handles and TALLY_ORG_ASSIGNEE can be checked before filing issues. An entry can set provisioned: false for a key the code reads that nobody has created. Its name still counts as declared, check skips its expiry, limit and missing findings, and a store holding a copy raises a provisioned gap so the facts get recorded. tally add --unprovisioned writes one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f3db174cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Recording an expiry on an unprovisioned entry failed validation, because the entry kept provisioned: false. A rotated key exists, so the field is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex review (session codex:01a1e506-0659-71c2-ae8b-d6605b8c29c8) reported one finding:
|
A gcp secret created before any version is added was observed like a stored key, so an entry marked provisioned: false got a provisioned gap and could be reported stale. The gcp reader now marks such a secret empty, and the provisioned, expiry, limit and stale checks for an unprovisioned entry count only copies that hold a value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Makes tally ready to be public and prepares the 0.6.0 release. - MIT `LICENSE` (Agent Labs, as in the other public agent-labs-dev repositories), `CODE_OF_CONDUCT.md`, `SECURITY.md` and `CONTRIBUTING.md`, YAML issue forms with blank issues off, and a PR template. agent-labs-dev has no `.github` repository, so tally carries its own copies (RS-3, RS-4). - README: CI, release and licence badges, an `Install` section for the CLI, and help and contributing links (RS-2). The install steps were run in a fresh clone: `bun link` then `tally --version` prints the version. - `package.json` 0.6.0, the Unreleased entries (from #28, both features, hence a minor bump) moved under `[0.6.0]`, and the README pins updated to `v0.6.0`. After merge, `git tag -s v0.6.0` on main publishes the release. Pre-publication checks: gitleaks over every commit and ref (70 commits, all branches, tags and PR heads) finds only the fixture already listed in `.gitleaksignore`; README, docs, the `pr-assets` screenshots, and every issue, PR and review comment were read for key values, customer names and internal URLs, and none were found. `bun run gate` passes locally (194 tests). Refs #23: making the repository public is a settings change, done separately. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
tally issues sync --dry-runnow shows who each issue would be assigned to. Every planned create and edit carriesassigneein JSON, and text output readscreate unused:org:Y -> someone. The assignee was already computed but dropped from the action.provisioned: falsefor a key the code reads that nobody has created yet. It needsexpiresandlimitunknown, its locations still declare the variable (nounregisteredfinding), andcheckreports no expiry or limit gap and nomissinglocation for it. When a store that was read holds a copy, check reports aprovisionedgap and the expiry and limit gaps come back, so the facts get recorded.tally add ... --unprovisionedwrites such an entry.tally schemalists the new field and option.[Unreleased]describe both.Test plan
bun run gate(biome, tsc, bun test, changelog check, validate)github:Ykey withTALLY_ORG_ASSIGNEE=someonegivesassignee: "someone"in JSON andcreate unused:org:Y -> someonein textprovisionedparsing, serialising, rules (no gaps, name declared, stored copy reported) andadd --unprovisionedCloses #27
Closes #25
🤖 Generated with Claude Code