Skip to content

feat: show planned assignees in dry runs and record unprovisioned keys - #28

Merged
cjber merged 3 commits into
mainfrom
cb/sweep-tally-25-27
Nov 18, 2026
Merged

cjber merged 3 commits into
mainfrom
cb/sweep-tally-25-27

Conversation

@cjber

@cjber cjber commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • tally issues sync --dry-run now shows who each issue would be assigned to. Every planned create and edit carries assignee in JSON, and text output reads create unused:org:Y -> someone. The assignee was already computed but dropped from the action.
  • An entry can set provisioned: false for a key the code reads that nobody has created yet. It needs expires and limit unknown, its locations still declare the variable (no unregistered finding), and check reports no expiry or limit gap and no missing location for it. When a store that was read holds a copy, check reports a provisioned gap and the expiry and limit gaps come back, so the facts get recorded. tally add ... --unprovisioned writes such an entry. tally schema lists the new field and option.
  • README, the tally skill and CHANGELOG [Unreleased] describe both.

Test plan

  • bun run gate (biome, tsc, bun test, changelog check, validate)
  • New CLI test follows the issues sync --dry-run does not show who each issue would be assigned to #27 repro: an organization-owned github:Y key with TALLY_ORG_ASSIGNEE=someone gives assignee: "someone" in JSON and create unused:org:Y -> someone in text
  • New tests for provisioned parsing, serialising, rules (no gaps, name declared, stored copy reported) and add --unprovisioned

Closes #27
Closes #25

🤖 Generated with Claude Code

issues sync --dry-run now carries the planned assignee on each create and
edit action (JSON "assignee", text "-> HANDLE"), so owner handles and
TALLY_ORG_ASSIGNEE can be checked before filing issues.

An entry can set provisioned: false for a key the code reads that nobody
has created. Its name still counts as declared, check skips its expiry,
limit and missing findings, and a store holding a copy raises a
provisioned gap so the facts get recorded. tally add --unprovisioned
writes one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T15:45:39.543113Z 2f3db17 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f3db174cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/reconcile.ts Resolved
Recording an expiry on an unprovisioned entry failed validation, because
the entry kept provisioned: false. A rotated key exists, so the field is
removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cjber

cjber commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Codex review (session codex:01a1e506-0659-71c2-ae8b-d6605b8c29c8) reported one finding:

  • [P2] src/schema.ts: tally rotated on an entry with provisioned: false failed validation, because it set an expiry but kept the field. Fixed in 878f329: rotated removes provisioned, and the CLI test now rotates an unprovisioned key and checks the field is gone.

A gcp secret created before any version is added was observed like a
stored key, so an entry marked provisioned: false got a provisioned gap
and could be reported stale. The gcp reader now marks such a secret
empty, and the provisioned, expiry, limit and stale checks for an
unprovisioned entry count only copies that hold a value.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cjber
cjber merged commit 3bb87a1 into main Nov 18, 2026
5 checks passed
@cjber
cjber deleted the cb/sweep-tally-25-27 branch November 18, 2026 08:09
cjber added a commit that referenced this pull request Nov 18, 2026
Makes tally ready to be public and prepares the 0.6.0 release.

- MIT `LICENSE` (Agent Labs, as in the other public agent-labs-dev
repositories), `CODE_OF_CONDUCT.md`, `SECURITY.md` and
`CONTRIBUTING.md`, YAML issue forms with blank issues off, and a PR
template. agent-labs-dev has no `.github` repository, so tally carries
its own copies (RS-3, RS-4).
- README: CI, release and licence badges, an `Install` section for the
CLI, and help and contributing links (RS-2). The install steps were run
in a fresh clone: `bun link` then `tally --version` prints the version.
- `package.json` 0.6.0, the Unreleased entries (from #28, both features,
hence a minor bump) moved under `[0.6.0]`, and the README pins updated
to `v0.6.0`. After merge, `git tag -s v0.6.0` on main publishes the
release.

Pre-publication checks: gitleaks over every commit and ref (70 commits,
all branches, tags and PR heads) finds only the fixture already listed
in `.gitleaksignore`; README, docs, the `pr-assets` screenshots, and
every issue, PR and review comment were read for key values, customer
names and internal URLs, and none were found.

`bun run gate` passes locally (194 tests).

Refs #23: making the repository public is a settings change, done
separately.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issues sync --dry-run does not show who each issue would be assigned to Record a key that the code reads but that was never provisioned

1 participant