Skip to content

Fix request cancellation wire method #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ololoshechkin merged 1 commit into from
Aug 11, 2026
+13 −1
Merged

Fix request cancellation wire method #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acp-model/src/commonMain/kotlin/com/agentclientprotocol/model/Methods.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public open class AcpMethod(public val methodName: MethodName) {
where TNotification : AcpNotification, TNotification : AcpWithSessionId

public object MetaMethods {
public object CancelRequest : AcpNotificationMethod<CancelRequestNotification>("\$/cancelRequest", CancelRequestNotification.serializer())
public object CancelRequest : AcpNotificationMethod<CancelRequestNotification>("\$/cancel_request", CancelRequestNotification.serializer())
}

public object AgentMethods {
Expand Down
12 changes: 12 additions & 0 deletions acp-model/src/commonTest/kotlin/com/agentclientprotocol/model/AcpMethodTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.agentclientprotocol.model

import com.agentclientprotocol.rpc.MethodName
import kotlin.test.Test
import kotlin.test.assertEquals

class AcpMethodTest {
@Test
fun `cancel request uses ACP wire method name`() {
assertEquals(MethodName("\$/cancel_request"), AcpMethod.MetaMethods.CancelRequest.methodName)
}
}
Loading