fix(tests): point nl-search e2e guard at the extractor manifest path - #2099
Merged
lgecse merged 2 commits intoSep 22, 2026
Merged
Conversation
ramizpolic
previously approved these changes
Sep 8, 2026
The BeforeAll guard in tests/e2e/local/15_nl_search_test.go checked for the OASF manifest at ~/.agntcy/oasf-sdk/manifest.json, but `dirctl init` provisions it at ~/.agntcy/oasf-sdk/extractor/manifest.json (see extractor.DefaultAssetDir in utils/extractor/config.go). Because the path never matched, the natural-language search suite silently skipped in every environment, including the e2e:test:local:local CI job, and had not run since it was added in agntcy#1770. Point the guard at the same path 16_extractor_enricher_test.go already uses, so the suite runs on a provisioned machine and still skips cleanly when the extractor is not provisioned. Closes agntcy#2090 Signed-off-by: Rohit <71192000+rohitsux@users.noreply.github.com>
lgecse
force-pushed
the
fix/nl-search-extractor-manifest-path
branch
from
September 22, 2026 10:55
051b487 to
0d77f14
Compare
lgecse
enabled auto-merge (squash)
September 22, 2026 10:56
…into the shared daemon Re-enabling the natural-language search suite exposed a test-isolation leak: its BeforeAll pushes directory-record.json (named "org.agntcy/directory", the same name the daemon self-publishes its skill record under) into the shared daemon but never deletes it. A later suite that searches by that name (14_skill_record_test.go) then pulls the leaked record and fails on its artifact media type. Delete the pushed record in AfterAll, mirroring 16_extractor_enricher_test.go. Signed-off-by: Rohit <71192000+rohitsux@users.noreply.github.com>
lgecse
force-pushed
the
fix/nl-search-extractor-manifest-path
branch
from
September 22, 2026 10:59
0d77f14 to
442ce37
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
csirmazbendeguz
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tests/e2e/local/15_nl_search_test.gonever runs. ItsBeforeAllguard checks for the OASF extractor manifest at the wrong path, so the "Natural-language search" suite skips in every environment — including thee2e:test:local:localCI job — and has silently reported green while executing nothing since it was added in #1770.Root cause
The guard looked for the manifest directly under
.agntcy/oasf-sdk:but
dirctl initprovisions it under.agntcy/oasf-sdk/extractor/, perextractor.DefaultAssetDir(utils/extractor/config.go).tests/e2e/local/16_extractor_enricher_test.goalready checks the correct path.Fix
Point the guard at the same
extractor/manifest.jsonpath thatdirctl initprovisions and16_extractor_enricher_test.gochecks (and align the comment wording). Theos.Stat-then-Skipstructure is unchanged, so an unprovisioned machine still skips cleanly.Verification
go vet ./e2e/local/passes;gofmtclean.ginkgo.Skip.dirctl init): the manifest now resolves, so the suite executes instead of skipping — CI'se2e:test:local:localjob will exercise it.Acceptance criteria
dirctl initprovisions and16_extractor_enricher_test.gochecksNote: because this re-enables a suite dormant since #1770, any assertions that have drifted will surface on the first provisioned CI run — flagging for reviewer visibility, as the issue anticipated.
Closes #2090