refactor!: remove naming.v1, dirctl mcp serve, and dirctl import - #2126
Draft
ramizpolic wants to merge 3 commits into
Draft
ramizpolic wants to merge 3 commits into
ramizpolic wants to merge 3 commits into
Conversation
Superseded by the identity/ownership claim model (identity.v1): DNS TXT/well-known JWKS domain verification is now one of several identity providers (dns/wellknown/did/spiffe) behind a common Resolver interface, rather than a naming-specific service. Removes the NamingService gRPC service (domain verification + name resolution), its server-side implementation (server/naming), storage (server/database/gorm/naming.go), reconciler task, CLI (dirctl naming), and client bindings. Migrates the sample consumer to the new GetIdentityStatus API.
Removes the `dirctl mcp serve` subcommand and its embedded github.com/agntcy/dir-mcp server. It was only ever a convenience wrapper around a separately released, standalone project; removing it also lets a later commit drop the naming.v1 wire-compat shim that dir-mcp's `verify_name` tool needed. `dirctl init agents` / `dirctl install` no longer derive a (now-broken) MCP server entry for the DIR record's own self-description — only the DIR skill artifact is installed. Updates docs and the example Helm chart values accordingly.
Removes the `dirctl import` subcommand and its github.com/agntcy/dir-importer dependency, along with the import-records CI workflow (dedicated to running it against production). Rewrites e2e export tests to seed data via `dirctl push` with pre-built OASF fixtures instead of importing raw A2A/MCP/SKILL.md sources, and drops the extractor-enricher e2e suite that only exercised `dirctl import --config`. Updates the CLI reference, usage guide, and skill-reference docs (the "Import and Export" page becomes "Export"-only). Also folds in two small naming.v1-era leftovers missed by the earlier naming-removal commit: a "nameVerificationStatus" -> "ownerVerificationStatus" parameter rename in catalog.go, and the dead NameVerificationHost e2e test-config field.
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification, Details: Examples: |
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).
|
This was referenced Sep 14, 2026
This was referenced Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full removal of naming.v1,
dirctl mcp serve, anddirctl import— stacked on top of #2125 (adds the identity/ownership claim system that supersedes naming.v1).NamingServicegRPC service (domain verification + name resolution), its server-side implementation (server/naming), storage, CLI (dirctl naming), reconciler task, and client bindings.client.Resolve/cli/util/referenceswitch to the identity-based resolve now that the name collision with naming.v1'sResolveis gone.dirctl mcp serve: removes the subcommand and itsgithub.com/agntcy/dir-mcpdependency (a convenience wrapper around a separately released, standalone project).dirctl init agents/dirctl installno longer derive a (now-broken) MCP server entry for the DIR record's own self-description — only the DIR skill artifact is installed.dirctl import: removes the subcommand and itsgithub.com/agntcy/dir-importerdependency, the dedicated import-records CI workflow, and rewrites e2e export tests to seed data viadirctl pushwith pre-built OASF fixtures instead of importing raw sources.Also updates the CLI reference, usage guide, skill-reference docs, README, renovate.json, and example Helm chart values accordingly.
Verification
go build && go vet && go testpass acrossapi,server,client,cli,reconciler,tests,samples/ard-over-adsat this PR's tip.Review note
Each individual commit is buildable on its own (naming.v1 removal → mcp removal → importer removal, in dependency order), but the middle commit intentionally leaves
clinon-buildable in isolation (the pinneddir-mcpdependency needs naming.v1'sGetVerificationInfotypes until it's also removed in the next commit) — only the full 3-commit sequence needs to be green.