cropArea not resetting after image rotation

[Malli1320]

@ailon

1. When we rotate an image , the crop Area is not adjusting to the rotated image size , therefore it allowing to crop beyond the image as below
   

2. Once the image is rotated, it takes the dimensions of the previous image only, it's not taking full width, Therefore it becomes difficult to resize the crop rectangle on rotated image in mobile screen as below
   
   

Here's the link to reproduce the above mentioned issues
https://codesandbox.io/p/sandbox/cropro-all-defaults-demo-forked-2lkll7

Can you suggest what needs to be done to to resolve above issues..

[ailon]

1. this is "by design" as the primary purpose is cropping. When you rotate in non-90deg ways the goal is to preserve all the image information and let the user decide whether they want to crop to fill a specific rectangle or leave the empty margins but keep all or most of the info.
2. I see what you mean but since the internal image is still that tall vertical image and sizing is based on that. A not-very-nice workaround but the only one I can think of is to rotate, do the initial crop, save, and then reopen cropro with the horizontal image to crop further. Can't think of anything better at the moment.

[wildhart]

I'm also expericing this issue. I understand your reasoning for wanting to keep the default behavour, although I agree with the OP that this behaviour is non-intuitive and not what users expect. I can't imagine a scenario where you'd want to rotate a portrait image to landscape and keep the black area above and below.

How about a compromise - could you add a configuration option to change the rotate behaviour to use the rotated image dimensions?

[ailon]

@wildhart what if someone gradually rotates to 90deg?

I think the main culprit here is that 90/180/270deg rotation is implemented the same way as "regular" gradual rotation just with predefined angles - hence it becomes fuzzy to determine what should happen. I guess a real solution would be to treat these specific rotations completely differently and then maybe there's a way to make the behavior consistent and predictable. But that's a slightly larger task than just a simple workaround (which I'm reluctant to implement and then support with all the side-effects that may arise).

[wildhart]

@wildhart what if someone gradually rotates to 90deg?

Then don't change the current behaviour.

Typically if you have a photo taken in the wrong orientation, then you only want to rotate it + or - 90deg, and nothing else, and would generally use a button instead of a gradual rotation.

So the logic could be fairly simple - if there have been no gradual rotations applied yet, and the user clicks one of the rotate left/right buttons, then rotate the image dimensions. If you want to have a flag to opt-in to this behaviour then feel free.

I'm already providing the markup and crop features (using marker.js and cropro), and also need to allow the user to fix photos which have been taken it the wrong orientation. I was hoping to just use the cropro rotate feature, but can't really.

[ailon]

What I meant is that internally currently there's no special behavior to rotate +/- 90deg. It works exactly the same as rotating 36.4deg. So this would mean having a totally separate behavior for those special cases yet keeping the current behavior for backwards compatibility.

In other words, I understand your points and generally agree but I can't promise a quick update to address your desired behavior. It would probably be a lot easier to just do it in a separate "action" outside of CROPRO.