Skip to content

bridge: call setOptions before decompileFunction (fix null options crash) - #24

Open
nextgens wants to merge 1 commit into
akiselev:masterfrom
nextgens:setoptions-fix
Open

bridge: call setOptions before decompileFunction (fix null options crash)#24
nextgens wants to merge 1 commit into
akiselev:masterfrom
nextgens:setoptions-fix

Conversation

@nextgens

Copy link
Copy Markdown

A bare DecompInterface has options==null (the constructor stores null). Without an explicit setOptions call, decompileFunction throws 'IllegalArgumentException: this.options is null' on a fresh bridge, or renders string data as PTR_s_ symbols instead of literals when a stale bridge happens to have options from a prior call.

Fix: add DecompInterface.setOptions(new DecompileOptions()) at all three decompiler sites (handleDecompile, handleSetVarType, handleDiffFunctions).

…ash)

A bare DecompInterface has options==null (the constructor stores null).
Without an explicit setOptions call, decompileFunction throws
'IllegalArgumentException: this.options is null' on a fresh bridge, or
renders string data as PTR_s_ symbols instead of literals when a stale
bridge happens to have options from a prior call.

Fix: add DecompInterface.setOptions(new DecompileOptions()) at all three
decompiler sites (handleDecompile, handleSetVarType, handleDiffFunctions).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant