Skip to content

fix(runtime): classify repeated adjudicated-revision validation failures (#293) - #295

Merged
akoita merged 1 commit into
mainfrom
codex/issue-293-adjudicated-revision-classification
Sep 3, 2026
Merged

fix(runtime): classify repeated adjudicated-revision validation failures (#293)#295
akoita merged 1 commit into
mainfrom
codex/issue-293-adjudicated-revision-classification

Conversation

@akoita

@akoita akoita commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Closes #293

Summary of Changes

  1. Failure-Stage Classification:

    • Introduced ProviderFailureStage and RunFailureStage distinguishing four content-free failure stages:
      • transport-parsing
      • response-schema-validation
      • artifact-schema-validation
      • factual-invariant-rejection
    • Propagated failureStage across ProviderAdapterError, RunError, and AuthorRetryFeedback.
    • Populated specific diagnostic codes in completeCvProposalIssues: "missing_evidence", "unsupported_claim", "factual_invariant_violation".
  2. Sanitized Deterministic Coverage:

    • Added packages/application/src/adjudicated-revision-validation.test.ts reproducing the confirmed 10-finding carrier shape (2 accepts, 2 rejects, 6 nuances, 2 accepted effect overrides).
    • Validated classification for each stage without leaking candidate prose, raw text, credentials, or file paths.
    • Validated that a representative valid revised artifact passes production validation to awaiting-approval.
  3. Hotspot Lineage:

    • Extracted proposalDiagnostics and invalidAuthorProposalError from packages/application/src/local.ts to packages/application/src/author-output.ts.
    • Reduced local.ts line count from 4,059 to 4,019 lines and lowered its architecture hotspot limit accordingly in scripts/architecture-hotspots.mjs.
  4. Quality Gates:

    • pnpm format, pnpm lint, pnpm typecheck, pnpm test (1,275 unit tests + 54 release tests), and pnpm validate pass 100% cleanly.

…res (#293)

- Introduce ProviderFailureStage and RunFailureStage distinguishing transport-parsing, response-schema-validation, artifact-schema-validation, and factual-invariant-rejection
- Propagate failureStage across ProviderAdapterError, RunError, and AuthorRetryFeedback without exposing private values or text
- Provide deterministic carrier tests covering all 4 failure stages and valid 10-finding reproduction
- Extract invalidAuthorProposalError to author-output.ts, lowering local.ts hotspot line count
@akoita
akoita merged commit d63c4b3 into main Sep 3, 2026
7 checks passed
@akoita
akoita deleted the codex/issue-293-adjudicated-revision-classification branch September 3, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(runtime): classify repeated adjudicated-revision validation failures

1 participant