-
Notifications
You must be signed in to change notification settings - Fork 85
[feat] pack the GenRec training forward through FlashAttention-2 #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tiankongdeguiji
merged 18 commits into
alibaba:master
from
WhiteSwan1:feat/genrec_flash_attention
Sep 22, 2026
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
98310f4
[perf] run GenRec with packed FlashAttention
WhiteSwan1 d85731f
[chore] merge upstream master into GenRec FlashAttention branch
WhiteSwan1 da3636e
[chore] merge upstream master into GenRec FlashAttention branch
WhiteSwan1 163e736
[fix] make GenRec a GPU-only, flash-attention-2 path
WhiteSwan1 4f5e298
[fix] run the genrec model tests on the GPU they now require
WhiteSwan1 4ec6768
[fix] skip the GenRec tests on the flash_attn wheel, not just on a GPU
WhiteSwan1 342660d
[feat] choose the GenRec attention kernel from the config
WhiteSwan1 01ef25a
[fix] return the GenRec tests to the CPU lane, and pin transformers
WhiteSwan1 6df33ca
[fix] read the attention kernel from our own config, not HF's private…
WhiteSwan1 3d82728
[fix] give each attention kernel the layout it can actually serve
WhiteSwan1 233a152
[chore] drop the cuDNN exclusion and a test it outlived
WhiteSwan1 45b3585
[fix] give the padded path its own positions, and cover it end to end
WhiteSwan1 d96493e
[chore] merge upstream master into GenRec FlashAttention branch
WhiteSwan1 27c2534
[chore] ship flash_attn for cp310 and cp312, not just cp311
WhiteSwan1 66dc5ec
[chore] bump version to 1.4.14
WhiteSwan1 53ab60b
[bugfix] filter prompt-less rows instead of failing the batch
WhiteSwan1 5043e15
[refactor] name the pad helper for what it returns
WhiteSwan1 c0c5835
[refactor] take attn_kernel as the transformers name
WhiteSwan1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,4 +23,4 @@ tensorboard | |
| torch==2.13.0 | ||
| torchmetrics==1.0.3 | ||
| torchrec==1.8.0 | ||
| transformers | ||
| transformers>=4.56 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.