Skip to content

[bugfix] post AI review inline comments instead of buffering them #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiankongdeguiji merged 1 commit into from
Sep 9, 2026
+10 −2
Merged

[bugfix] post AI review inline comments instead of buffering them #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/code_review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,13 @@ jobs:
REPO_OWNER: ${{ github.repository_owner }}
REPO_NAME: ${{ github.event.repository.name }}
PR_NUMBER: ${{ github.event.pull_request.number }}
# Post inline comments as they are created. Left unset, the MCP server
# buffers them into /tmp for a post-step that only claude-code-action
# runs; these jobs drive the CLI directly, so nothing would post them.
CLASSIFY_INLINE_COMMENTS: "false"
# No ANTHROPIC_API_KEY — uses stored OAuth from `claude /login` on the runner
# MCP server inherits env vars (GITHUB_TOKEN, REPO_OWNER, REPO_NAME, PR_NUMBER)
# MCP server inherits env vars (GITHUB_TOKEN, REPO_OWNER, REPO_NAME,
# PR_NUMBER, CLASSIFY_INLINE_COMMENTS)
run: |
set -euo pipefail

Expand Down Expand Up @@ -314,7 +319,9 @@ jobs:
grep -q '^model *=' "$CODEX_HOME/config.toml" || {
echo "::error::set model = \"...\" in the runner's ~/.codex/config.toml"; exit 1; }

# The MCP server gets its token here (config file, not argv or codex env)
# The MCP server gets its token here (config file, not argv or codex
# env), and this block is its whole environment, so the inline-comment
# buffer opt-out has to be repeated here
cat >> "$CODEX_HOME/config.toml" << EOF

[mcp_servers.github_inline_comment]
Expand All @@ -327,6 +334,7 @@ jobs:
REPO_OWNER = "${REPO_OWNER}"
REPO_NAME = "${REPO_NAME}"
PR_NUMBER = "${PR_NUMBER}"
CLASSIFY_INLINE_COMMENTS = "false"
EOF
chmod 600 "$CODEX_HOME/config.toml"

Expand Down
Loading