Skip to content

Add Maithili language README.maithili.md - #49

Open
VINAY-MANDAL wants to merge 2 commits into
alphacrack:mainfrom
VINAY-MANDAL:development
Open

Add Maithili language README.maithili.md#49
VINAY-MANDAL wants to merge 2 commits into
alphacrack:mainfrom
VINAY-MANDAL:development

Conversation

@VINAY-MANDAL

Copy link
Copy Markdown

Summary

Motivation / Audit Reference

Test Evidence

  • pytest -v runs green locally
  • Coverage is at or above the critical-module gate (cli / transpile / linter ≥90%)
  • New tests added for any new behavior or regression
  • python -m maithili_dsl examples/*.dmai smoke-tested the examples
  • python -m maithili_dsl --version shows the expected version

Security Considerations

Breaking Changes

Checklist

  • CHANGELOG.md updated (Unreleased section)
  • Version bumped if this is a release PR
  • No new runtime dependencies added (or justification provided below)
  • Docs updated if user-visible behavior changed

@VINAY-MANDAL
VINAY-MANDAL requested a review from alphacrack as a code owner July 19, 2026 17:33

@alphacrack alphacrack left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the kind of contribution #11 hoped for — धन्यवाद! 🙏 The structure mirrors the English README section-for-section and most of it reads naturally. A few things to fix before merge:

Objective content errors (must fix):

  1. Features list says देवनागरी अंक (0-9) — the original (and the language!) is ०-९. The Devanagari numerals are the whole point of that bullet.
  2. Module-translation example says गणितगणित — should be गणितmath.

Structural (should fix):
3. The file isn't linked from README.md#11 suggested a line at the top of the English README (e.g. [मैथिली मे पढ़ू](README.maithili.md)), otherwise nobody will find it.
4. Leftover untranslated fragments: duplicated "Clone the repo:" above the Maithili line, and the "### 🔧 Install CLI Tool (cross-platform)" heading.
5. The stray first line # README.md — the English README has the same wart, but no need to copy it here.

Coordination notes (non-blocking):

  • The keyword table copies the English table's 11 rows, which is already missing 5 mappings (#39). Fine to merge as-is and let #39 update both files together — just flagging so they don't drift separately.
  • For future PRs, please branch off development with a topic branch rather than PRing from your fork's development directly (see CONTRIBUTING.md) — it makes follow-up pushes cleaner.

On phrasing (मे vs में, "के साथ", "जैसे" etc.) I'll defer to native speakers — posting a pointer on #11 inviting review would be a great move. Excited to get this in!

@alphacrack alphacrack added documentation Improvements or additions to documentation translation Maithili / Devanagari documentation and message translation labels Jul 20, 2026
@VINAY-MANDAL

VINAY-MANDAL commented Jul 20, 2026 via email

Copy link
Copy Markdown
Author

@alphacrack

Copy link
Copy Markdown
Owner

हम जनकपुरधाम सँ छी।

@alphacrack

Copy link
Copy Markdown
Owner

Thanks for keeping this open — the Maithili README is genuinely valuable and I'd love to get it merged. It can't go in yet; the items from my earlier review are still outstanding, plus CI is red. Concretely:

1. Two factual errors in the translated content (README.maithili.md):

  • Line 12: देवनागरी अंक (\0-9`) → should be **०-९`** (the Devanagari numerals — that bullet is literally about them).
  • Line 13: \गणित` → `गणित` → should be **गणितmath`** (the mapping is Maithili→Python).

2. Not discoverable. The file isn't linked from README.md. Please add a line near the top of the English README, e.g. [मैथिली मे पढ़ू](README.maithili.md), so readers can find it.

3. CI is failing / the branch is stale. This PR is ~2 weeks old and predates several merges (the branch was renamed to main, plus the v0.4.0 work). Please rebase onto the latest main and push — that should clear the red ci-ok. Also, the branch is a fork's development with a self-merge commit; a clean topic branch off main would be tidier per the updated CONTRIBUTING.

Once the two text fixes + the README link are in and CI is green, this is good to merge. On the Maithili phrasing itself I'll defer to native speakers — worth pinging #11 for review. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation translation Maithili / Devanagari documentation and message translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants