Skip to content

Pioneer-style responsive controller UI - #2

Open
stefanwuthrich wants to merge 5 commits into
mainfrom
feat/pioneer-controller-ui
Open

Pioneer-style responsive controller UI#2
stefanwuthrich wants to merge 5 commits into
mainfrom
feat/pioneer-controller-ui

Conversation

@stefanwuthrich

Copy link
Copy Markdown
Contributor

Summary

  • Rebuild the app as a no-scroll hardware chassis: LCD on top, platters left/right, mixer in the centre. PERFORM is side-by-side scrolling waveforms; BROWSE / INFO / SETTINGS swap LCD content only.
  • Pad banks (Hot Cue / Loop / Jump) live in display-only view.store. Empty platters show LOAD; decode errors stay amber on that platter. Below 1280px the focused deck is staged and the peer is a strip — hiding a platter never pauses it.
  • Self-hosted IBM Plex, DESIGN.md tokens, keyboard cheatsheet under SETTINGS, and skipped waveform paints when the LCD tab is hidden.

Test plan

  • npm run typecheck, lint, test, build
  • Playwright smoke (26) including LOAD error, 1440 no document scroll, 390 one-deck stage
  • Visual QA on a 1440×900 window: no page header, LOAD on both platters, zoomed waveforms only on the LCD
  • At ~390px: play both decks, confirm the hidden platter keeps running, then focus the peer with 1/2
  • SETTINGS shows the keyboard list; MIDI connect still works

Made with Cursor

agiloch and others added 4 commits August 30, 2026 15:32
[gstack-context]
Decisions: 1A hardware chassis — LCD first, platters second, mixer third; no desktop page scroll
Remaining: Pass 1 LCD-mode vs chassis, then passes 2-7
Tried: none
Skill: /plan-design-review
[/gstack-context]

Co-authored-by: Cursor <cursoragent@cursor.com>
[gstack-context]
Decisions: 11 locked (chassis, LCD swap, hands-only decks, LOAD/error on platter, Plex, recessed chrome, DESIGN.md, 3 viewports, split type size, 8-pad banks)
Remaining: implement T1-T7; /design-review after chassis
Tried: gstack design variants blocked on missing OpenAI key; used Cursor images for the board
Skill: /plan-design-review
[/gstack-context]

Co-authored-by: Cursor <cursoragent@cursor.com>
[gstack-context]
Decisions: full T1-T7 PR; display-only phone stage; PadBank wrap; vendor Plex woff2; full e2e matrix; skip hidden waveform draws (T8)
Remaining: implement T1-T8
Tried: Codex outside voice skipped (CLI not installed)
Skill: /plan-eng-review
[/gstack-context]

Co-authored-by: Cursor <cursoragent@cursor.com>
Fill the viewport with LCD waveforms, pad banks, and LOAD platters so mixing
is hardware chrome instead of a scrolling page. Display-only layout: hidden
platters never pause a deck.

Co-authored-by: Cursor <cursoragent@cursor.com>
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants