Repository navigation
fix(config): store Windows secrets in Credential Manager - #182
Merged
francoischalifour merged 3 commits intoNov 9, 2026
Merged
francoischalifour merged 3 commits into
francoischalifour merged 3 commits into
Conversation
Contributor
Author
|
@francoischalifour, please review the remaining Windows credential-store fix for #151. Full CI is green, including real Windows Credential Manager Unicode/multiline read/write/delete and plaintext-migration coverage, canonical integration verification, the minimum Bun runtime, and all four native builds. The existing synchronous secret-store API and macOS/Unix behavior stay unchanged. Windows native calls use a fixed PowerShell wrapper with secret data on stdin; errors fail closed, and migration removes plaintext only after a successful native write. If it has not been reviewed by November 15, I will leave the PR open without another ping. |
- Read all Altertable credentials with one CredEnumerate call and reuse the snapshot until another CLI process writes, tracked by a revision marker, so per-request auth no longer starts PowerShell each time. - Store blobs as UTF-8 and reject secrets over the 2,560-byte vault limit before spawning. - Report PowerShell absence, timeouts, restricted language mode, missing logon-session vaults and Win32 error codes, each with the file-backend opt-out. - Skip deletes for absent credentials and no-op credentials-file rewrites.
francoischalifour
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the remaining Windows credential-protection work in #151. #158 already stopped applying POSIX mode checks to Windows files; this PR replaces the default plaintext fallback there with the current user's Windows Credential Manager.
ALTERTABLE_SECRET_BACKEND=filefor CI and addwindowsfor an explicit native-store requirement.Closes #151
Verification
bun run checkon pinned Bun 1.4.4 passes: 869 unit tests (one Windows-native test skipped on Linux), 157 black-box tests, 42 browser tests, typechecks/lint/format/generated checks, both knip checks, and packed npm consumer smoke.Windows verification
The real Windows vault test passed: Unicode/multiline round-trip, existence/deletion, no plaintext file for new writes, and removal of a migrated plaintext credential. The Linux/macOS/Windows user-directory checks and CodeQL analysis also passed. Full CI is now green, including canonical repository/integration verification, minimum Bun runtime, all four native compilation/smoke checks, CodeQL, and the real Windows vault test.