Repository navigation
fix(update): give binary downloads their own timeout and keep failure causes - #184
Conversation
… causes The 10s manual timeout covered the whole release binary body (~94 MB), so slower connections aborted mid-download and the error was replaced with a generic "Unable to install GitHub release binary." message. - Add a 5-minute `timeoutsMs.download` for the binary download. - Report download timeouts and network failures with the asset name and cause. - Include the underlying reason in the install fallback error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
albert20260301
left a comment
There was a problem hiding this comment.
Verified the failure against a real loopback HTTP response that sends headers and one byte immediately, then delays the body: the old updater reports the generic install error; this patch succeeds with the separate download deadline. A shorter download deadline produces TimeoutError/exit 9 with the asset name and leaves the original binary unchanged.
Local static checks, 869 unit tests, 157 black-box tests and build pass; required CI is green. Checksum/version verification and atomic replacement remain intact. This verifies the patch, not publication: installed older updaters still need the documented retry/manual bootstrap to acquire the fix.
🤖 I have created a release *beep* *boop* --- ## [1.15.1](v1.15.0...v1.15.1) (2026-11-08) ### Bug Fixes * **update:** give binary downloads their own timeout and keep failure causes ([#184](#184)) ([98804ab](98804ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: altertable-release[bot] <345426372+altertable-release[bot]@users.noreply.github.com>
|
The fix is now available in CLI 1.15.1 on npm and GitHub Releases. Verified the archive integrity, extracted version/update help, and identical SHA-256 for the GitHub asset, npm bundle and a fresh build of the release commit. The updater source exactly matches the reviewed patch with the passing real-HTTP slow-body/rollback regression. An older installed updater still uses its old download timeout. If updating through it fails, acquire 1.15.1 via the package manager or a manual release-binary download; the new timeout applies once the fixed updater is installed. This verification did not replace a live installed CLI. |
Problem
altertable updatefailed with only[ERROR] Unable to install GitHub release binary.The 10s manual timeout (
AbortSignal.timeout) covered the whole release binary body (~94 MB), not just the response headers. On slower connections,response.arrayBuffer()aborted with a plainTimeoutError. That isn't aCliError, so the catch-all replaced it with a generic message and the cause was lost.Changes
UpdaterConfig.timeoutsMs.downloadfor the binary download (overridable throughdownloadTimeoutMs). Metadata and checksum requests keep the 10s timeout.fetchBytesreportsTimed out downloading <asset> after Ns.as aTimeoutError(exit code 9), and other failures asUnable to download <asset>: <reason>.Tests
TimeoutErrorwith the asset name, and the existing binary is left in place.NetworkErrorwith its cause.bun run check --quickpasses.Note: users on a release without this fix still hit the old behavior until they update once (by retrying or with a manual binary download).
🤖 Generated with Claude Code