Repository navigation
feat(charts): add interactive legend focus - #148
Conversation
albert20260301
left a comment
There was a problem hiding this comment.
Native series sharing a primitive dataKey cannot be focused unless the caller supplies explicit IDs. I reproduced this on 50c0f31 in Chromium with two native Recharts <Line dataKey="value" name="Alpha|Beta" /> children inside ComposedChart: clicking Alpha leaves two curves visible and its aria-pressed immediately returns to false. Giving those same lines distinct IDs makes the click select one curve with aria-pressed="true".
applyNativeLegendInteraction only generates an ID for non-primitive data keys, while createLegendItemKeys disambiguates duplicate primitive keys with object-identity suffixes. The focus selection therefore does not match either series key, and reconciliation resets it. Please use the same unique series identity on both sides for this supported native composition, and cover duplicate primitive data keys without explicit IDs in the browser tests.
Local static checks pass. The new single-key accessor case does not cover this collision.
|
The duplicate-key fix in e32c262 passes the independent Chromium probe: without explicit IDs, clicking Alpha now leaves one curve and Approval is still waiting on required CI: Tests (4/4) fails |
albert20260301
left a comment
There was a problem hiding this comment.
The duplicate-key identity fix and its browser regression are verified on e32c262. The independent Chromium probe now focuses a native series without explicit IDs; both local legend/inspection suites pass (50 tests). The required inspection retry and aggregate gate are now green on this unchanged head.
The earlier full local static, 1,203-test, package-consumer and starter checks passed; the subsequent identity-fix delta was reviewed and built separately. The requested changes are resolved.
🤖 I have created a release *beep* *boop* --- ## [0.77.0](v0.76.0...v0.77.0) (2026-11-12) ### ⚠ BREAKING CHANGES * give each widget its own query, loaded near the viewport ([#145](#145)) ### Features * **charts:** add interactive legend focus ([#148](#148)) ([a1f40a5](a1f40a5)) * give each widget its own query, loaded near the viewport ([#145](#145)) ([4f9fcd5](4f9fcd5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: altertable-release[bot] <345426372+altertable-release[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Available in v0.77.0. I verified all seven npm archives against their registry SHA-512 values and fresh archives built from the release commit; every packaged file matches. A clean installed-package Chromium smoke test also confirms that native series sharing a data key focus correctly without explicit IDs. This release also includes the breaking per-widget query/loading migration; see the view guide at the release tag. Existing consumer bundles still need their own migration, rebuild and deployment. |
What this brings
Checks
bun run check:staticbun run test --maxWorkers=6— 1,203 tests passedbun run check:packagebun run check:starter