Skip to content

test: expect primary foreground widget titles - #152

Merged
francoischalifour merged 1 commit into
mainfrom
fc/fix-widget-heading-test-264a3e
Nov 16, 2026
Merged

francoischalifour merged 1 commit into
mainfrom
fc/fix-widget-heading-test-264a3e

Conversation

@francoischalifour

Copy link
Copy Markdown
Member

#149 switched widget titles from --atbl-muted to --atbl-text, but tests/public-api/apps-dates.test.ts still expected them to match the muted table header color, so main's Check job has failed since. The test now asserts the heading color resolves to --atbl-text; the section-hierarchy assertions are unchanged.

@albert20260301 albert20260301 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertion now checks the intended primary foreground token while retaining shared typography and section-hierarchy coverage. Reviewed the full diff at 31ce672; local static checks and all five date browser tests pass, and required CI is green. This corrects the stale test behind #149's main-branch failure without changing widget styling.

@robinvrd robinvrd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@francoischalifour
francoischalifour merged commit 86cbc83 into main Nov 16, 2026
13 checks passed
@francoischalifour
francoischalifour deleted the fc/fix-widget-heading-test-264a3e branch November 16, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants