Skip to content

[test] AI review check #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Taiizor wants to merge 1 commit into from
Closed

[test] AI review check #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/lib.alya
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,17 @@
pub function print_version(app: CliApp)
say cli_format_version(app)
end

## Counts non-empty args (test helper for AI review).
pub function count_args(args: array) -> int
let n = 0
let unused_x = 1

@github-actions github-actions Bot Oct 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Ground-truth lint:FAIL warning[unused-var]: variable 'unused_x' is declared but never read; same line also causes fmt:FAIL needs formatting due to 2-space indent. Remove the line.

let i = 0
while i < len(args) - 1

@github-actions github-actions Bot Oct 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

major: Off-by-one vs stated intent 'Counts non-empty args': 'while i < len(args) - 1' never examines the last element, so a non-empty final arg is missed.

Suggested change
while i < len(args) - 1
while i < len(args)

if len(args[i]) > 0
n += 1
end
i += 1
end
return n
end
Loading