Repository navigation
Release v1.3.0: viewport-aware Looking Glass focus - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Looking Glass users can inspect a cropped part of the source, so off-screen depth should not continuously move the visible subject. Manual focus also needs to remain stable across long shots without allowing an accidental distant click or a scene cut to leave the display black.
Scope
The new placement behavior is gated to Looking Glass Pinhole + Auto Source View. SBS, monitor, generic WebXR, Free Orbit, and Creative Relief retain their existing behavior.
Validation
git diff --checkRelease
This PR prepares VideoDepthViewer3D v1.3.0. After PR CI and post-merge
mainCI pass, the merge commit will receive annotated tagv1.3.0and a GitHub Release.