🔒 Fix: SQL Injection + XSS vulnerabilities (CWE-89, CWE-79) - #1
Open
javokhir-sec wants to merge 1 commit into
Open
🔒 Fix: SQL Injection + XSS vulnerabilities (CWE-89, CWE-79)#1javokhir-sec wants to merge 1 commit into
javokhir-sec wants to merge 1 commit into
Conversation
Addresses multiple critical vulnerabilities: - CWE-89: SQL Injection in DELETE (delete_product.php) - switch to prepared statement - CWE-89: SQL Injection in SELECT (edit_product.php) - switch to prepared statement - CWE-89: SQL Injection in UPDATE (edit_product.php) - switch to prepared statement - CWE-89: SQL Injection in INSERT (index.php) - switch to prepared statement - CWE-79: Stored XSS in product listing (index.php) - add htmlspecialchars() on output - Fix incorrect column name references (Designation→name_product, etc.) Discovered by: Javokhir Tursunboyev (github.com/javokhir-sec) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛡️ Security Fix Summary
This PR fixes 5 Critical SQL Injection vulnerabilities and 1 Stored XSS vulnerability discovered by security researcher Javokhir Tursunboyev.
Vulnerabilities Fixed
Public/delete_product.phpPublic/edit_product.phpPublic/edit_product.phpPublic/index.phpPublic/index.phpChanges Made
$mysqli->query()string interpolation with$mysqli->prepare()+bind_param()htmlspecialchars()on all database output to prevent XSSDesignation→name_product, etc.)Proof of Concept (Before Fix)
After Fix
All queries use parameterized prepared statements. SQL injection is no longer possible.
🔐 Discovered by: Javokhir Tursunboyev
📧 CVE Request: Pending via MITRE CNA-LR