Repository navigation
Legal f accessibility - #68
Merged
Merged
Conversation
The docs site had one skip link, on the landing page. Everything else -- the
docs shell, sign-in, sign-up, join, device, password reset, CLI login -- had
none, so a keyboard user tabbed the whole header on every page.
What was actually broken, beyond the skip links:
* The sign-in and password-reset forms wrote their status and error messages
into a <p hidden> and then unhid it. `hidden` takes the element out of the
accessibility tree, so "Invalid login credentials" was announced to nobody.
Both live regions now stay in the tree and are emptied instead, and a failed
submit marks the fields aria-invalid pointing at the message.
* Secondary text was #67676f on black: 3.5:1, at 12-14px. 48 elements on the
landing page and 7 on every docs page failed 1.4.3. The two dim tokens are
now 6:1. Input and button borders were 1.7:1 against their surface, under
1.4.11's 3:1 for a control boundary; they take a new --control-line token.
* The docs header is a bare row of six links with no mobile menu, so it ran
260px off the side of a 320px viewport. It wraps now.
* Standalone links -- the docs cards, "Next:", "Forgot your password?" -- were
16-20px tall, under 2.5.8's 24px.
* The hero's step strip was marked up as a tablist with no tabpanels and no
arrow-key handling. It is a group of toggle buttons and now says so.
* Code blocks scroll sideways with no way for a keyboard to reach the scroll.
docs/accessibility.md states the target (WCAG 2.2 AA), what was verified, and
eight limitations including the big one: this has not been driven with a screen
reader, so it does not claim full conformance.
apps/docs-site/src/a11y.test.ts runs axe-core over every page and over every
state the sign-in, join, and device pages render, and asserts the skip links
separately since axe has no rule for them. It runs under `pnpm test`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… amsultan2010/legal-f-accessibility
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.