Show an unsupported-browser notice for Safari - #423
Merged
Conversation
andeplane
changed the title
andeplane
enabled auto-merge
September 7, 2026 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari currently cannot run Atomify's credentialless / SharedArrayBuffer simulation engine. Detect Safari/WebKit before starting the engine and show: “Safari is not supported for simulations. Use Chrome or Firefox on a desktop computer.” Examples and projects remain browsable, but simulation controls stay disabled and the engine is not downloaded.
The sidebar displays a persistent error instead of an endless loading indicator, with an accessible label and tooltip when collapsed. Also show an error when cross-origin isolation is unavailable or engine initialization rejects.
The existing isolation policy, service worker, engine implementation, and thumbnail rendering are unchanged. This PR explicitly marks Safari unsupported; it does not implement Safari compatibility or a fallback engine.
Validation:
npm run typechecknpm run test:run: 460 tests passednpm run buildnpx playwright test --config playwright.safari.config.ts: three checks passed (three browser-inapplicable combinations skipped). WebKit shows the unsupported notice, skips the engine download, and keeps examples browsable. Chromium completes a simulation and shows an error when isolation is unavailable.Closes #421