Repository navigation
ci: raise normal tier timeout to 45 minutes - #21
Merged
Merged
Conversation
Healthy lint and portable shard jobs that used to take 20-21 minutes now reach the 30 minute bound on slower runners and get cancelled while still making steady progress. Raise the shared normal tier to 45 minutes and update the policy doc and workflow test that pin it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Raise the time limit on the fork's CI jobs that keep timing out.
Context: on the fork andrew-codes/firstmate, three PRs in a row (PR 19, PR 20 twice) had a CI job cancelled at its 30-minute
timeout-minuteslimit with no test or lint failure, and each passed or got further on rerun. Lint 2 used to take 20-21 minutes; on the latest rerun it linted 283 files steadily from 13:52 to 14:22 and ran out of time (no hang). "Behavior portable serial 9" was also cancelled at the limit twice after its tests had been passing. "Full suite" then fails only because one of those jobs was cancelled. .github/workflows/ci.yml gives these jobs the "Normal tier" 30-minute limit and documents a timeout policy near the top.What Changed
timeout-minutesfrom 30 to 45 for every normal-tier job in.github/workflows/ci.yml(lint partitions, portable parallel and serial shards, macOS stock Bash). Added a header comment explaining that healthy 20-21 minute lint and shard jobs were being cancelled at the old bound while still making steady progress.docs/fm-test-portable-shards.mdto the 45-minute bound and its rationale.tests/fm-ci-workflow.test.shso the normal-tier check expects the single shared 45-minute budget, including the comment and failure message.Risk Assessment
✅ Low: The change raises the five normal-tier job timeouts from 30 to 45 minutes and updates the policy comment, the docs table and the guard test to match, and the Herdr 75-minute backstop and fast-tier limits are unaffected.
Testing
I ran the workflow guard test, which runs the workflow through its consumers and checks the timeout tiers. All checks passed, including "normal tier jobs share one 45 minute budget". I also parsed the YAML: the five normal-tier jobs (lint, the three portable test lanes, macOS) are at 45, the heavy lanes at 75, and the fast jobs at 5. No GitHub-hosted run was driven. Whether the jobs now finish inside 45 minutes is only knowable from a real CI run.
bash tests/fm-ci-workflow.test.shexited 0 and printed 'ok - normal tier jobs share one 45 minute budget'Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bash tests/fm-ci-workflow.test.shexited 0 and printed 'ok - normal tier jobs share one 45 minute budget'bash tests/fm-ci-workflow.test.shParsed .github/workflows/ci.yml with Ruby YAML and listed each job's timeout-minutes✅ **Document** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.