Repository navigation
refactor(bazel/rules_angular): update ng_library to use @angular/build:library - #4011
Merged
Merged
Conversation
alan-agius4
added
action: blocked
alan-agius4
force-pushed
the
architect-lib-builder
branch
from
October 7, 2026 07:38
73dfd2f to
5f78e38
Compare
alan-agius4
marked this pull request as ready for review
October 7, 2026 07:47
alan-agius4
force-pushed
the
architect-lib-builder
branch
from
October 7, 2026 07:48
5f78e38 to
40b37c3
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Angular Bazel rules by simplifying the ng_library macro, adding integration tests with a sample application and library, and introducing a serve_args parameter to ng_application. Feedback highlights that referencing the @angular npm scope directly as a dependency is invalid and will cause Bazel build errors, and that unconditionally modifying .value.architect.build.options in ng_config.bzl will crash jq if a project lacks a build target. Additionally, it is recommended to use list concatenation instead of .append() for cleaner Starlark code.
alan-agius4
force-pushed
the
architect-lib-builder
branch
3 times, most recently
from
October 7, 2026 08:15
ce1a929 to
2b218ae
Compare
Update tsconfig jq transformation in `ng_config` to read each project's `root` from `angular.json` rather than assuming a `projects/<project>` folder structure.
alan-agius4
force-pushed
the
architect-lib-builder
branch
from
October 7, 2026 15:35
bb57c6a to
6996dad
Compare
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
ng_libraryandng_configinrules_angulararchitect rules and adds test targets undertest/architect.