Skip to content

build: update octokit monorepo - #4020

Merged
alan-agius4 merged 2 commits into
angular:mainfrom
alan-agius4:pr-takeover-3946
Oct 9, 2026
Merged

alan-agius4 merged 2 commits into
angular:mainfrom
alan-agius4:pr-takeover-3946

Conversation

@alan-agius4

Copy link
Copy Markdown
Contributor

See associated pull request for more information.

Closes #3946 as a pr takeover

@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 9, 2026
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @octokit/openapi-types dependency across several packages and updates references to use RestEndpointMethodTypes from @octokit/rest instead. It also bumps @octokit/types and @octokit/plugin-paginate-rest versions, and updates a Bazel environment variable to use $(rootpath). Feedback on the changes highlights a missing Bazel dependency on @octokit/rest in ng-dev/utils/BUILD.bazel which is required for the new import in octokit-types.ts to compile successfully.

Comment thread ng-dev/utils/BUILD.bazel
],
env = {
"GITHUB_REPOSITORY": "angular/angular",
"GITHUB_EVENT_PATH": "$(location :issue-context.json)",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(location) is deprecated.

@josephperrott josephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4
alan-agius4 merged commit 5fb5ac8 into angular:main Oct 9, 2026
17 checks passed
@alan-agius4

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4
alan-agius4 deleted the pr-takeover-3946 branch October 9, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants