Repository navigation
build: lock file maintenance - #4022
Merged
Merged
Conversation
See associated pull request for more information. Closes angular#4001 as a pr takeover
alan-agius4
added
action: merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily consists of dependency and lockfile updates across several modules and integration tests. It also modifies the esbuild configuration in apps/functions/BUILD.bazel to treat ../../package.json as an external dependency. Feedback on this change highlights that marking the package file as external could lead to runtime MODULE_NOT_FOUND errors in serverless environments like Firebase Functions, where directory structures are flattened, and suggests bundling the file directly instead.
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See associated pull request for more information.
Closes #4001 as a pr takeover