Repository navigation
feat(screenshots): a recording toolbar, smaller movies with sound, and playback in the editor - #2166
Merged
Merged
Conversation
… (t1607) Labs › Screenshots gets a Recording group (Scale Retina to 1x, Max resolution, Frame rate, Quality), each with a hex settings key; defaults 1x, Original, 30 fps, High (HEVC 0.50). The editor copies a recording's movie file, and its export-size pop-up (Original, 1080p, 720p) shows an estimate for the span kept, re-encoding off the UI thread with progress on the pressed button. (t1607)
… mixed into the movie (t1607)
…macOS-only (t1607)
… a deadline (t1607)
… once and save in order (t1607)
… keeps no audio; Annotate may take the record key while the Lab is off (t1607)
… the recording it came from (t1607)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labs › Screenshots can now record the screen properly: ⌘⇧5 opens a small recording toolbar, the movie is sharp and small, it can keep your voice and the computer's sound, and the editor plays it back before you export.
Everything here is behind Labs › Screenshots, which is off by default. Annotate's own captures, dictation and the microphone dictation uses are unchanged.
Before / After
Recording toolbar
Icons only, with names in tooltips. With two displays, a chevron inside Full screen picks which one. Light mode: after.
Recording editor
A play button beside the trim strip (or Space) plays the kept span with sound, and a white playhead moves through it. The size chip says what the export will weigh. Save is now Export. Light mode: after.
What changes
Keyframes now come every 2 s rather than every 5 s, so a trim without re-encoding lands close to the cut. That costs about 5% on a busy screen.
Proof
cargo clippy --bin hexis clean. The screenshot, capture, i18n, settings and labs tests pass (618).Read:
src/rune_ui/capture_capsule/toolbar.rsandsrc/screenshots/toolbar.rs(the toolbar),src/capture_host/microphone.rs(the second microphone), andeditor/clip.rs(playback).