Repository navigation
iOS: onboarding always shows the Hex key, and practice needs Hex's dictation - #2211
Merged
Merged
Conversation
David (iPhone 17 Pro Max, iOS 26.6.2, TestFlight) switched to Hex with the globe in onboarding's practice and saw "a big blank bar" with no Hex key, so he used iOS's own dictation mic instead. Not reproduced in the iOS 27.2 (iPhone 17 Pro) and 26.4 (iPhone 17 Pro Max) simulators, from first launch with Full Access granted before and while the keyboard ran: the keys, suggestions and Hex key are up in the first screenshot after the switch (0.5 s) every time. In the keyboard only the recording bar hides the Hex key with the keys up, and nothing in onboarding starts it, so the blank bar was most likely iOS's empty panel before the keyboard's first frame on that iPhone (as in #2185's report). The app couldn't tell, and the page kept saying "tap the Hex key". What changed - The keyboard notes in the App Group when its view has appeared (viewDidAppear, after its first frame) and when it goes away (viewWillDisappear): KeyboardBridge.recordKeyboardShown/Hidden. - KeyboardPresence.isShown: shown since it last appeared and not hidden since, with a sign of life (that appearance or the Full Access report it repeats every 5 s while shown) under 7 s old. - The practice page: after a keyboard switch by hand, when Hex's keyboard isn't on screen within 2 s (another keyboard, iOS's dictation, or Hex's never drew), it says "Don't see the Hex key? Tap the globe until Hex's keyboard comes up", gone as soon as Hex's keyboard is up. Only with Full Access, which the keyboard needs to write the App Group; without it the existing Full Access note shows. The three practice notes share one view (practiceNote); zh-Hans string added; README. Verified (anomastudio, ad-hoc signed Debug build, iPhone 17 Pro iOS 27.2, onboarding from first launch): switching from Hex to Apple's keyboard shows the note after 2 s, switching back hides it; tapping iOS's mic under Hex's keyboard takes Hex's keyboard off screen (hiddenAt written). Not verified on a physical iPhone.
David finished onboarding's practice with iOS's dictation (the system mic at the bottom right), not Hex: the practice counted any three words in its field once a keyboard had ever reported Full Access, so iOS's dictation, or Apple's keyboard, passed it. Reproduced on an iOS 27.2 simulator: three words typed on Apple's keyboard showed "That's Hex". What changed - Words count as typed only when they arrive while Hex's keyboard is on screen (KeyboardPresence, from the previous change): iOS's dictation and other keyboards take Hex's keyboard off screen, so their text never counts. OnboardingPractice.isDone takes typedWithHex (the words Hex's keyboard was up for, never more than the field holds) in place of the field's word count; wordsAdded works out a change's new words. - Text that arrives while Hex's keyboard is off screen shows "That came from iOS dictation or another keyboard, not Hex. Tap the Hex key on Hex's keyboard." and the practice doesn't finish; Hex's own input clears it, as does emptying the field. Only with Full Access (without it the Full Access note shows). zh-Hans string added; README. - Unchanged: a dictation Hex's keyboard inserted (lastInsertedResultID) still finishes it at once, and snapshot fixtures count their text. Verified (anomastudio, ad-hoc signed Debug build, iPhone 17 Pro iOS 27.2, practice reached from first launch): - Before: "See you at" typed on Apple's keyboard showed "That's Hex". - After: the same text keeps "Your turn" and shows the note; switching to Hex and typing "we" clears the note and still isn't done; "go now" with Hex's keys shows "That's Hex". - Tapping iOS's mic under Hex's keyboard takes Hex's keyboard off screen (the simulator has no microphone, so iOS's dictation inserted nothing). - xcodebuild test (both changes): 620 passed, 1 skipped, 0 failures. Not verified on a physical iPhone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
David (iPhone 17 Pro Max, iOS 26.6.2, TestFlight) switched to Hex with the globe in onboarding's practice, saw "a big blank bar" with no Hex key, used iOS's own dictation mic instead, and the practice said "That's Hex".
1. The blank bar (not reproduced, now explained to the user)
viewDidAppear) and when it goes away (viewWillDisappear). SeeKeyboardPresence.2. Practice passed on iOS's dictation (fixed)
No strip or key changes. The keyboard change is two App Group writes, in
viewDidAppearandviewWillDisappear.Verified (anomastudio, ad-hoc signed Debug, iPhone 17 Pro, iOS 27.2):
xcodebuild test: 620 passed, 1 skipped.Not verified on a physical iPhone.