feat: Add retries to download_file.

[prmukherj]

Context

Some arguments like max_retries were missing from download_file method in examples.

Change Summary

Instead of having a local implementation, just use the implementation already in ansys-tools-common by flattening out paths wherever required to match PyFluent's style.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[seanpearsonuk]

That's an awkward API because the return_without_path argument changes the semantics of the return value. It makes sense to introduce a new method that returns the downloaded file as a pathlib.Path, e.g. download_file_path(), and deprecate return_without_path on the existing download_file() method. This would give us a cleaner API while preserving backwards compatibility for existing callers.

@prmukherj @mkundu1
@RobPasMue @AlejandroFernandezLuces

[prmukherj]

yes, makes sense @seanpearsonuk. This is a pyfluent specific implementation. Will update it. Thank you

[seanpearsonuk]

Ok, thanks, explains why I didn't remember it from the recent PR.