feat(c): add source context to manifest and profile parse errors - #4633
Open
amoeba wants to merge 4 commits into
Open
feat(c): add source context to manifest and profile parse errors#4633amoeba wants to merge 4 commits into
amoeba wants to merge 4 commits into
Conversation
lidavidm
approved these changes
Jul 30, 2026
lidavidm
left a comment
lidavidm
left a comment
Member
There was a problem hiding this comment.
Seems pre-commit is still unhappy
Member
Author
|
Should be good now. 🤞 |
lidavidm
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I have an manifest or profile that's invalid TOML, such as,
I get a vague error:
It turns out the toml++ library can show the line and column number where the parse error occurred. This PR adds that context if it's available so we get a better error: