fix(arrow/array): make dictionary suffix null indexes relative - #1064
Open
fallintoplace wants to merge 1 commit into
Open
fix(arrow/array): make dictionary suffix null indexes relative#1064fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
serramatutu
approved these changes
Jul 30, 2026
serramatutu
left a comment
serramatutu
left a comment
Contributor
There was a problem hiding this comment.
Ran the test before/after the fix, it does repro the issue. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Clear the validity bit using the null index relative to
startOffsetwhen exporting a dictionary suffix.Why
GetDictArrayDatabuilds a new dictionary whose bitmap starts at the requested offset, but it previously cleared the absolute memo-table index. For nonzero offsets this could mark the wrong dictionary entry valid while still reporting one null.The regression test exports a suffix containing a null and verifies that the corresponding relative entry is null.
Testing
go test ./arrow/array