fix(arrow/array): always release JSON reader builder - #1065
Open
fallintoplace wants to merge 4 commits into
Open
fix(arrow/array): always release JSON reader builder#1065fallintoplace wants to merge 4 commits into
fallintoplace wants to merge 4 commits into
Conversation
serramatutu
suggested changes
Jul 30, 2026
| assert.False(t, rdr.Next()) | ||
| } | ||
|
|
||
| func TestJSONReaderReleaseBuilder(t *testing.T) { |
Contributor
There was a problem hiding this comment.
I reverted your change to json_reader.go and ran the test you introduced. The test did not break, i.e it does not reproduce any memory leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Release the JSON reader record builder whenever the final reader reference is released, independently of whether a current record batch exists.
Why
The builder release was nested under the current-record check. A decode error can leave
curnil while the builder still owns buffers from values parsed before the error, so releasing the reader did not free those buffers.The regression test parses an object far enough to allocate builder storage, triggers a duplicate-key error before a record batch is produced, and verifies with a checked allocator that
Releasefrees the partial builder state.Testing
go test ./arrow/arraygo test -race ./arrow/array -run TestJSONReaderReleaseBuilderAfterPartialReadError