fix(parquet): serialize column chunk file offsets - #1073
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #891
Problem
ColumnChunkMetaDataBuilder.Finishcomputed the first page offset for internal row-group metadata but did not copy it to the serialized ThriftColumnChunk.FileOffsetfield. Serialized metadata therefore reported the default zero value even when the chunk started elsewhere.Change
Populate
ColumnChunk.FileOffsetfrom the computed first page offset:Coverage
The metadata round-trip test verifies dictionary and non-dictionary column chunks before and after serialization.
Validation
go test ./parquet/metadata