feat(capacity-limiter): explore a borrower-aware capacity limiter - #287
Closed
orthur2 wants to merge 1 commit into
Closed
feat(capacity-limiter): explore a borrower-aware capacity limiter#287orthur2 wants to merge 1 commit into
orthur2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR explores #224 with a working implementation, tests, and benchmarks. I plan to close it without merging and keep the code available for reference.
CapacityLimiterwith explicit borrower identities and RAII permitsDesign Notes
I also tried a
Semaphorewrapper and a sharded borrower registry. This PR keeps borrower identities, capacity, and the waiter queue under one mutex. It allows concurrent resize calls without caller retries, but duplicates some semaphore accounting and queue management.Local measurements favored this implementation in most runs, though it did not win consistently under contention. The benchmarks help compare implementation costs; they do not establish a need for another core primitive.
I would leave #224 in the backlog until a concrete Rust use case shows where borrower tracking provides a useful guarantee beyond the existing semaphore and owned permits.
Refs #224.