CASSSIDECAR-496: Disable Netty wire logging on the HTTP server - #381
Open
rustyrazorblade wants to merge 1 commit into
Open
CASSSIDECAR-496: Disable Netty wire logging on the HTTP server#381rustyrazorblade wants to merge 1 commit into
rustyrazorblade wants to merge 1 commit into
Conversation
rustyrazorblade
force-pushed
the
fix-http-log-activity-hex-dumps
branch
from
August 29, 2026 00:49
59a0582 to
1cb54db
Compare
rustyrazorblade
changed the title
HttpServerOptionsProvider hardcoded setLogActivity(true), installing Netty's LoggingHandler on every HTTP connection. It was the only hardcoded option in a method where every other value is read from SidecarConfiguration. On a 3-node cluster running the published sidecar image this produced 8.6 million log lines in one hour, roughly 96% of all log volume, because ByteBufUtil.appendPrettyHexDump turns a single 95,504-byte response into about 6,000 lines. The dumps contain request and response bodies in cleartext; since schema endpoints return DDL, CQL statements are written to the logs as well. It only fires when the process starts without logback.configurationFile, which is supplied solely by the Gradle-generated start scripts. A directly launched jar gets no logback configuration and falls back to logback's default of root DEBUG to ConsoleAppender, which is the common container path. The test suite could not catch it either: logback-test.xml pins LoggingHandler to info.
rustyrazorblade
force-pushed
the
fix-http-log-activity-hex-dumps
branch
from
August 29, 2026 00:51
1cb54db to
199e421
Compare
yifan-c
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CASSSIDECAR-496
HttpServerOptionsProviderhardcodedsetLogActivity(true), installing Netty'sLoggingHandleron every HTTP connection. It was the only hardcoded option in a method where every other value is read fromSidecarConfiguration.On a 3-node cluster running the
ghcr.io/apache/cassandra-sidecarimage this produced 8.6 million log lines in one hour, roughly 96% of all log volume, becauseByteBufUtil.appendPrettyHexDumpturns a single 95,504-byte response into about 6,000 lines. The dumps contain request and response bodies in cleartext; since schema endpoints return DDL, CQL statements are written to the logs as well:It only fires when the process starts without
logback.configurationFile, which is supplied solely by the Gradle-generated start scripts. A directly launched jar gets no logback configuration and falls back to logback's default of root DEBUG to ConsoleAppender — the common container path. The test suite could not catch it either:server/src/test/resources/logback-test.xmlpinsLoggingHandlerto info.