Fix AbstractLinkedList addAll returning true for an empty collection - #726
Merged
garydgregory merged 1 commit intoAug 17, 2026
Merged
Conversation
Member
|
@rootvector2 Thank you for the PR, reviewed and merged 🚀 |
garydgregory
added a commit
that referenced
this pull request
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addAll(int, Collection)hard-codesreturn true, so adding an empty collection reports a change that never happened, breaking theList.addAllcontract (returntrueonly if the list changed). Spotted because the class's ownLinkedSubList.addAllalready returnsfalsefor an empty collection, as doesTreeList.addAll. The fix returnsfalsefor an empty collection after thegetNoderange check, so an out-of-range index still throwsIndexOutOfBoundsException.AbstractLinkedListJava21is a copy of this class with the same defect and gets the same one-line fix. Regression test inAbstractListTestruns against every list impl; it fails before forCursorableLinkedList,NodeCachingLinkedListand theAbstractLinkedListJava21default list, and passes after.mvn; that'smvnon the command line by itself.