fix(ios): exlude CDVAssetLibrary on deploymentTarget 26, add documentation - #660
Open
GitToTheHub wants to merge 1 commit into
Open
fix(ios): exlude CDVAssetLibrary on deploymentTarget 26, add documentation#660GitToTheHub wants to merge 1 commit into
CDVAssetLibrary on deploymentTarget 26, add documentation#660GitToTheHub wants to merge 1 commit into
Conversation
…mentation - The Assets Library by Apple is deprecated since iOS 9 and removed completly when targeting iOS 26. - Suppress deprecation warnings for `CDVAssetLibrary.m` - Document `CDVAssetLibraryFilesystem.h` - Add documentation to `README.md` about `asset-library://...` urls
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
AssetsLibrary is deprecated since iOS 9 and unavailable when the app deployment target is iOS 26+, which causes compile failures (see #652). This code path only existed to resolve legacy
asset-library://...media URLs (Photos-managed pictures/videos) viacdvfile://localhost/assets-library/.....Apple recommends to use the PhotoKit framework, but which is not a drop-in replacement for this legacy URL model and would require broader behavior changes beyond this fix.
Therefore this PR focuses on buildability and compatibility: keep legacy behavior for lower deployment targets, and exclude the AssetsLibrary-based path for deployment target 26+.
Other changes:
CDVAssetLibrary.mdeploymentTarget26 these deprecation warnings don't need to be fixed.CDVAssetLibraryFilesystem.hREADME.mdaboutasset-library://...urlsDescription
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))