fix: separate storage location accounting for internal cache holds - #20150
Open
clintropolis wants to merge 2 commits into
Open
fix: separate storage location accounting for internal cache holds#20150clintropolis wants to merge 2 commits into
clintropolis wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partially loaded segments use the same type of 'holds' a query places on cache entries for 'structural' reasons such as preventing metadata entry or parent bundle entries from being evicted, partial load rules also place holds to pin all entries that the rule requires be loaded, etc. This PR distinguishes these internal usages by adding methods to
StorageLocationwhich internal callers can use to influence how metrics are reported so that these internal usages do not count as cache hits and the like.