feat(clients): unify client search with pagination - #533
Conversation
The page exposes one client-scoped free-text query, so align its navigation label and title with the capability it actually provides. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
E2E — mocked backend🎭 E2E Tests✅ All green — 354 passed · 0 failed · 1 skipped, across 28 spec files in 7m 11s. By spec file
All 355 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 34441218627 from |
E2E — real Fineract🎭 E2E Tests✅ All green — 77 passed · 0 failed · 0 skipped · 1 flaky, across 23 spec files in 6m 59s.
|
| Spec | ✅ | ❌ | ⏭️ | Time |
|---|---|---|---|---|
| backend.setup.ts | 3 | 0 | 0 | 6.0s |
| batch-api-operations.spec.ts | 5 | 0 | 0 | 31.6s |
| center-servicing.spec.ts | 2 | 0 | 0 | 18.0s |
| client-transfer.spec.ts | 4 | 0 | 0 | 45.4s |
| deposit-account-servicing.spec.ts | 3 | 0 | 0 | 25.0s |
| deposit-product-configuration.spec.ts | 3 | 0 | 0 | 15.9s |
| group-membership.spec.ts | 3 | 0 | 0 | 46.6s |
| loan-account-actions.spec.ts | 3 | 0 | 0 | 22.9s |
| loan-charge-off.spec.ts | 2 | 0 | 0 | 18.6s |
| loan-product-accounting.spec.ts | 1 | 0 | 0 | 35.2s |
| loan-servicing.spec.ts | 2 | 0 | 0 | 20.8s |
| login.spec.ts | 4 | 0 | 0 | 6.2s |
| parity-screens.spec.ts | 8 | 0 | 0 | 44.6s |
| rbac-backend-restricted-user.spec.ts | 7 | 0 | 0 | 36.4s |
| rbac-multi-permission.spec.ts | 9 | 0 | 0 | 58.8s |
| full-demo.spec.ts | 1 | 0 | 0 | 1m 5s |
| loan-lifecycle.spec.ts | 4 | 0 | 0 | 2m 5s |
| loan-schedule-type.spec.ts | 3 | 0 | 0 | 35.9s |
| report-parameter-backend.spec.ts | 4 | 0 | 0 | 23.1s |
| savings-transaction-correction.spec.ts | 1 | 0 | 0 | 6.8s |
| share-account-servicing.spec.ts | 2 | 0 | 0 | 18.4s |
| share-product-accounting.spec.ts | 1 | 0 | 0 | 23.9s |
| teller-cash-management.spec.ts | 2 | 0 | 0 | 35.8s |
All 77 tests — click to expand
backend.setup.ts
- ✅ seed backend reference data —
2.0s - ✅ seed backend reference data —
2.1s - ✅ seed backend reference data —
1.9s
batch-api-operations.spec.ts
- ✅ Batch API Operations against Fineract › runs the sample batch scenario — create client, create loan, add and read back a charge —
6.4s - ✅ Batch API Operations against Fineract › shows a parse error instead of submitting when the batch input is not valid JSON —
6.1s - ✅ Batch API enclosingTransaction semantics against Fineract › rolls back the earlier steps when enclosingTransaction is true and a later step fails —
5.6s - ✅ Batch API enclosingTransaction semantics against Fineract › does not roll back the earlier steps when enclosingTransaction is false and a later step fails —
9.4s(retried 1×) - ✅ Batch API Operations on a mobile viewport against Fineract › the sample batch scenario is reachable and works by touch at mobile width —
4.2s
center-servicing.spec.ts
- ✅ Center servicing › a center is activated, staffed and given a group —
12.8s - ✅ Center servicing › notes are recorded against the center —
5.2s
client-transfer.spec.ts
- ✅ Client transfer between offices › a proposed transfer is held until the destination accepts, and then the client moves —
11.5s - ✅ Client transfer between offices › a rejected transfer leaves the client on hold, and withdrawing is the way back —
12.0s - ✅ Client transfer between offices › a client can be transferred in one step when the user may act for both offices —
10.7s - ✅ Client staff assignment › an officer can be assigned and then removed —
11.2s
deposit-account-servicing.spec.ts
- ✅ Term deposit account servicing › an account is approved, activated and closed before maturity —
10.5s - ✅ Term deposit account servicing › a deposit is recorded, listed, and reversed without leaving the list —
8.9s - ✅ Term deposit account servicing › an application can be rejected instead of approved —
5.6s
deposit-product-configuration.spec.ts
- ✅ Deposit product configuration › a fixed deposit product survives being edited —
5.4s - ✅ Deposit product configuration › a recurring deposit product can be created at all —
5.1s - ✅ Deposit product configuration › a savings product carries its accounting configuration —
5.4s
group-membership.spec.ts
- ✅ Group membership and lifecycle › a group is activated, staffed, given members and a committee, then emptied —
19.9s - ✅ Group membership and lifecycle › notes are recorded against the group and can be removed again —
8.3s - ✅ Group membership and lifecycle › an empty group is closed with a reason, and a group with members is refused —
18.4s
loan-account-actions.spec.ts
- ✅ Loan account lifecycle actions › new action menu items appear only for active loans —
6.2s - ✅ Loan account lifecycle actions › undo disbursal shows a confirm dialog and reverts the loan to Approved —
8.9s - ✅ Loan account lifecycle actions › write off requires confirmation and moves the loan out of Active status —
7.8s
loan-charge-off.spec.ts
- ✅ Loan servicing commands › charges a loan off through the UI and reverses it —
10.1s - ✅ Loan servicing commands › records a goodwill credit through the shared transaction form —
8.5s
loan-product-accounting.spec.ts
- ✅ Loan product accounting › a cash-accounting product is configured, round-trips on edit, and posts to the ledger —
35.2s
loan-servicing.spec.ts
- ✅ Loan servicing: notes and transaction adjustment › notes can be added and removed, with a confirm dialog on delete —
9.7s - ✅ Loan servicing: notes and transaction adjustment › a repayment transaction can be viewed and adjusted with a corrected amount —
11.1s
login.spec.ts
- ✅ Login › login page displays correctly —
1.4s - ✅ Login › login form has required fields —
1.4s - ✅ Login › submit button is disabled when form is empty —
2.2s - ✅ Login › submit button is enabled when form is filled —
1.2s
parity-screens.spec.ts
- ✅ Screens added for platform parity › a manual journal entry can be read whole and reversed —
5.2s - ✅ Screens added for platform parity › an entry that is already reversed is not offered again —
5.0s - ✅ Screens added for platform parity › a report definition can be created, edited and deleted; a core one cannot —
5.4s - ✅ Screens added for platform parity › a core report opens read-only with only its in-use setting —
5.0s - ✅ Screens added for platform parity › a pending loan is approved from the queue, in a batch —
6.0s - ✅ Screens added for platform parity › a fixed deposit is listed as a deposit, not as a savings account —
5.9s - ✅ Screens added for platform parity › an office has a screen, and it carries its custom fields —
4.5s - ✅ Screens added for platform parity › a savings account carries notes, and the note survives a reload —
7.6s
rbac-backend-restricted-user.spec.ts
- ✅ a genuinely restricted Fineract user › holds exactly the permissions their role was granted —
242ms - ✅ a genuinely restricted Fineract user › reaches the screen their permission covers —
4.9s - ✅ a genuinely restricted Fineract user › is refused a screen their permission does not cover, by URL and by the backend —
5.2s - ✅ a genuinely restricted Fineract user › is refused a write screen they can read the list for, and the write itself —
6.1s - ✅ a genuinely restricted Fineract user › is not offered the actions it would be refused for —
4.7s - ✅ a genuinely restricted Fineract user › is shown an action it cannot take, disabled and saying what it needs —
5.5s - ✅ a genuinely restricted Fineract user › the superuser the rest of the suite uses is unaffected —
9.6s
rbac-multi-permission.spec.ts
- ✅ a route declaring more than one permission code (OR semantics) › is admitted by either declared code alone —
5.4s - ✅ a route declaring more than one permission code (OR semantics) › is admitted by the other declared code alone —
4.8s - ✅ a route declaring more than one permission code (OR semantics) › is refused when holding neither declared code, by the router and by the backend —
5.2s - ✅ ALL_FUNCTIONS_READ, against the real Fineract permission catalogue › reaches read screens across modules it holds no specific code for —
9.5s - ✅ ALL_FUNCTIONS_READ, against the real Fineract permission catalogue › is refused every write screen, and the writes themselves —
6.9s - ✅ a restricted session across a real page reload › keeps the same permission boundary after reloading, not just after a fresh login —
9.7s - ✅ a second real action-level gate, distinct from loan repayment › is shown the Approve action disabled and naming what it needs, refused by the backend too —
6.2s - ✅ Security module writes (users, roles), against the real backend › reaches the list screens but is refused the write screens —
10.8s - ✅ Security module writes (users, roles), against the real backend › is refused creating a user and modifying a role, by the backend itself —
312ms
full-demo.spec.ts
- ✅ Full feature demo recording › walk through loan schedule type, lifecycle, custom fields, collateral, and disbursement —
1m 5s
loan-lifecycle.spec.ts
- ✅ Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Cumulative loan —
33.1s - ✅ Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Progressive loan —
33.6s - ✅ Loan lifecycle: creation, approval, disbursement › an approved loan can be returned to pending approval —
30.0s - ✅ Loan lifecycle: creation, approval, disbursement › the delinquency tab reads a real loan, and the empty data tabs stay hidden —
28.5s
loan-schedule-type.spec.ts
- ✅ Loan Schedule Type (Cumulative vs Progressive) › loan products list shows a schedule type chip per product —
9.6s - ✅ Loan Schedule Type (Cumulative vs Progressive) › create a Progressive loan product end-to-end and verify it round-trips —
15.9s - ✅ Loan Schedule Type (Cumulative vs Progressive) › loan creation shows the schedule type badge for a Progressive product —
10.5s
report-parameter-backend.spec.ts
- ✅ Dynamic report parameters against Fineract › keeps the parameter form available when a report has cascading lookups —
5.2s - ✅ Dynamic report parameters against Fineract › changing Office changes the Client Listing row set —
6.2s - ✅ Cascading report parameters against Fineract › sends the parent value to the child lookup and clears the child when it changes —
7.6s - ✅ Chart reports against Fineract › renders a chart report as a chart rather than a table —
4.1s
savings-transaction-correction.spec.ts
- ✅ Savings transaction correction › a deposit is reversed and a hold is released —
6.8s
share-account-servicing.spec.ts
- ✅ Share account servicing › an account is approved, activated, traded and closed —
12.3s - ✅ Share account servicing › an application can be rejected —
6.1s
share-product-accounting.spec.ts
- ✅ Share product accounting › a share product is mapped to equity and round-trips on edit —
23.9s
teller-cash-management.spec.ts
- ✅ Teller cash management › a cashier is listed, receives an allocation, and settles cash back —
23.8s - ✅ Teller cash management › settling more than the cashier holds is refused and the form stays usable —
12.0s
Slowest 10 — what the shard counts should be tuned against
| Test | Spec | Time |
|---|---|---|
| Full feature demo recording › walk through loan schedule type, lifecycle, custom fields, collateral, and disbursement | full-demo.spec.ts |
1m 5s |
| Loan product accounting › a cash-accounting product is configured, round-trips on edit, and posts to the ledger | loan-product-accounting.spec.ts |
35.2s |
| Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Progressive loan | loan-lifecycle.spec.ts |
33.6s |
| Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Cumulative loan | loan-lifecycle.spec.ts |
33.1s |
| Loan lifecycle: creation, approval, disbursement › an approved loan can be returned to pending approval | loan-lifecycle.spec.ts |
30.0s |
| Loan lifecycle: creation, approval, disbursement › the delinquency tab reads a real loan, and the empty data tabs stay hidden | loan-lifecycle.spec.ts |
28.5s |
| Share product accounting › a share product is mapped to equity and round-trips on edit | share-product-accounting.spec.ts |
23.9s |
| Teller cash management › a cashier is listed, receives an allocation, and settles cash back | teller-cash-management.spec.ts |
23.8s |
| Group membership and lifecycle › a group is activated, staffed, given members and a committee, then emptied | group-membership.spec.ts |
19.9s |
| Group membership and lifecycle › an empty group is closed with a reason, and a group with members is refused | group-membership.spec.ts |
18.4s |
📼 Download the HTML report, videos and traces — see the playwright-report-backend artifact.
Generated by run 34441218627 from 6b86563. The run executed a fork branch, so treat its contents as unverified.
Aman-Mittal
left a comment
There was a problem hiding this comment.
I think this is the appropirate fix, you can remove move the advanced ai search
You should extend its capabilities and create a single client search section with pagination
Unify the client list and text search, preserve status filtering and supported sorting, and cover desktop and mobile pagination. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
Preserve exact v2 search totals of 1, 11, and 21 without changing the v1 unknown-total behavior. Wait for debounced search responses before the pagination regression advances. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
|
@Aman-Mittal Addressed; current head is The complete fork CI and E2E both passed on this head, including real-Fineract shards, mobile, two-factor and full unit suites. The upstream signed-commit check also passed. The PR description contains the complete evidence and screenshots. Upstream CI/E2E/CodeQL still require maintainer approval. Please approve those upstream runs and review the consolidated flow. |
Require titles for rendered pages and preserve redirect configuration in the RouterTestingHarness. Verify that the legacy client-search URL navigates to the client list and uses its translated title. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
Require titles for rendered pages and preserve redirect configuration in the RouterTestingHarness. Verify that the legacy client-search URL navigates to the client list and uses its translated title. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
|
can you also share screenshot and videos |
What and why
Consolidate the standalone client text search into the Clients table, as requested in review. One search field supports paginated name, account-number, external-ID and mobile-number searches;
/clients/searchredirects to/clientsand its duplicate navigation entry is removed.Keep status filtering in the same table. The backend's status-filtered endpoint supports name matching, so that mode displays a matching placeholder and hint. Preserve supported sorting, reset unsupported Office sorting for broad text queries, and reset pagination when the query changes. Exact v2 totals such as 1, 11 and 21 render as numbers while v1 retains its unknown-total behavior.
Closes #493
AI assistance was used for implementation, regression tests, review and validation. This extends the original label correction to address the maintainer's request for one client-search section with pagination.
Verification
6b8656359d9df9a9c0fa5dbcbed9a0cba1604c83. This includes the full application unit suites in UTC and America/New_York, microfrontend tests, ESLint, formatting, production/container builds, API-client drift, translation/navigation checks, security, GA readiness and license/RAT checks.Screenshots
Captured from the final code with mocked client data.
Desktop: one client search, page two, and one Clients navigation entry
Mobile: search and status controls with client cards
Checklist
src/app/api/.