Skip to content

Fix SMS gateway workflow path trigger - #5919

Closed
NkwaTambe wants to merge 222 commits into
apache:developfrom
ADORSYS-GIS:fix/sms-gateway-workflow-path
Closed

NkwaTambe wants to merge 222 commits into
apache:developfrom
ADORSYS-GIS:fix/sms-gateway-workflow-path

Conversation

@NkwaTambe

Copy link
Copy Markdown

Summary

  • Fixed broken paths filter in .github/workflows/build-push-sms-gateway.yml
  • Changed ../../fineract-adorsys-sms-gateway/** to fineract-adorsys-sms-gateway/**
  • The old path used relative ../ segments that never matched any files, so the SMS gateway Docker build has not triggered since this workflow was added
  • Config CLI workflow paths are already correct — no changes needed

Why it matters

This workflow is responsible for building and pushing the SMS Gateway native image to GHCR. Without this fix, it silently never runs, leaving stale container images.

francis-pouatcha and others added 30 commits July 16, 2025 17:58
Signed-off-by: Francis Pouatcha <francis.pouatcha@adorsys.com>
…act-in-docker-setup-documentation

remote debugging for fineract in docker setup documentation
NkwaTambe and others added 28 commits April 29, 2026 08:42
Merge upstream Apache into adorsys fork – 2026-04-27
fix(ci): correct sms gateway path in workflow
Revert all changes and merges from April 27-29 to restore stable state
Merge upstream Apache into adorsys fork – 2026-05-04
…ories-path

fix: update jib extraDirectories to use existing fineract-adorsys-pen…
Merge upstream Apache into adorsys fork – 2026-05-11
Merge upstream Apache into adorsys fork – 2026-05-18
Merge upstream Apache into adorsys fork – 2026-05-25
- Introduced OtpService for generating and validating OTPs with rate limiting and expiration.
- Added new models for OTP requests and responses.
- Implemented multiple SMS providers including Console, Mock, Twilio, and Custom HTTP.
- Enhanced SmsService to support provider selection and message normalization.
- Updated SmsController to handle OTP generation and validation endpoints.
- Added ApiExceptionHandler for centralized error handling.
- Integrated Micrometer for metrics tracking on SMS sending and OTP events.
- Created a comprehensive provider guide in PROVIDERS.md for easy configuration and usage.
- Refactored existing services to improve logging and error handling.
Merge upstream Apache into adorsys fork – 2026-06-01
Add support for Orange and Avlytext SMS providers, including OAuth2
authentication for Orange and API key authentication for Avlytext.
The implementation includes a retry mechanism with exponential backoff,
MSISDN normalization for Orange, and a new console provider for local
development testing.

- Add OrangeSmsProvider with OAuth2 client credentials flow
- Add AvlytextSmsProvider with API key authentication
- Implement RetryHelper for robust message delivery
- Add documentation for new providers and configuration
- Update application configuration and README with new environment variables
- Add console provider for local debugging and testing
…ub.com:ADORSYS-GIS/fineract into feat/implement-webank-registration-otp-service
…ration-otp-service

feat: Add OTP functionality and SMS provider integration
The paths filter used '../../fineract-adorsys-sms-gateway/**' which
never matches since the folder lives at repo root. Fixed to
'fineract-adorsys-sms-gateway/**' so merges to develop/main that
touch the SMS gateway actually trigger the Docker build and push.
@NkwaTambe NkwaTambe closed this Jun 2, 2026
@NkwaTambe
NkwaTambe deleted the fix/sms-gateway-workflow-path branch June 2, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants