[filesystems] Fix S3 assumed role ARN not used for file I/O - #3779
Open
qzyu999 wants to merge 1 commit into
Open
[filesystems] Fix S3 assumed role ARN not used for file I/O#3779qzyu999 wants to merge 1 commit into
qzyu999 wants to merge 1 commit into
Conversation
When s3.assumed.role.arn is configured in server.yaml without static credentials, configure AssumedRoleCredentialProvider so that the assumed role is actually used for S3 operations (remote log, KV snapshots, lake offsets). Previously, the code only logged a message and returned without setting the credential provider, causing S3A to use ambient credentials from the default chain instead of the configured role. Closes apache#3761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When s3.assumed.role.arn is configured in server.yaml without static credentials, Fluss should use that role for all S3 file I/O operations. Previously, the code only logged "Using default AWS credential chain with AssumeRole" and returned without actually configuring the AssumedRoleCredentialProvider, causing all S3 operations (remote log, KV snapshots, lake offsets) to use ambient credentials instead.
Changes
Test Plan
S3FileSystemPluginTest.testServerModeWithRoleArnOnlyverifies AssumedRoleCredentialProvider is configuredS3FileSystemPluginTest.testServerModeWithStaticKeysAndRoleArnverifies precedence behaviorCloses #3761