Spark: Bound runaway serializable-isolation and concurrent-refresh tests

[wombatu-kun]

Closes #16359

Summary

Several spark-extensions concurrency tests ran two worker threads in a barrier-synchronized loop bounded by Integer.MAX_VALUE while the main thread blocked on assertThatThrownBy(<op>Future::get) with no timeout, expecting a conflict exception. When that exception was never thrown, nothing bounded either thread — the append thread kept committing data files until CI hit its wall-clock limit or ran out of disk (as in #16303, where the runaway filled the GitHub Actions disk and was retriggered several times before the cause was found). This makes those tests fail fast instead of relying on external limits.

What changed

• Bounded both worker loops with a shared MAX_OPERATIONS = 20 constant — the same value the sibling *WithSnapshotIsolation tests already use with this identical harness — so the loop can no longer run unbounded.
• Wrapped the wait in Future.get(OPERATION_TIMEOUT_MINUTES, TimeUnit.MINUTES) (5 minutes) and cancelled the operation future in finally, so a stuck operation is interrupted and the wait can't block forever.
• Hoisted MAX_OPERATIONS and OPERATION_TIMEOUT_MINUTES into SparkRowLevelOperationsTestBase so these concurrency tests share one bound (the snapshot-isolation siblings now reference the same constant).

Affected methods in spark/v4.1: testMergeWithSerializableIsolation, testDeleteWithSerializableIsolation, testUpdateWithSerializableIsolation. The copy-on-write testMergeWithConcurrentTableRefresh, testDeleteWithConcurrentTableRefresh and testUpdateWithConcurrentTableRefresh exist only in spark/v3.5 and spark/v4.0, so they are covered by the follow-up backport PR rather than here.

In a passing run the conflict still fires within the first couple of iterations, so behavior is unchanged; in a regression the bounded loop plus timeout make the test fail fast with a clear assertion instead of exhausting CI resources.

---

AI Disclosure

• Model: Claude Opus 4.7
• Platform/Tool: Claude Code
• Human Oversight: fully reviewed
• Prompt Summary: Bound the runaway serializable-isolation and concurrent-refresh Spark tests with iteration and time limits.

[github-actions]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

[wombatu-kun]

not stale