Parquet: Fix variant STRING metrics bounds to use UTF-8 byte order - #17397
Open
vishnuprakaz wants to merge 1 commit into
Open
Parquet: Fix variant STRING metrics bounds to use UTF-8 byte order#17397vishnuprakaz wants to merge 1 commit into
vishnuprakaz wants to merge 1 commit into
Conversation
uros-b
approved these changes
Jul 28, 2026
Member
|
Nice fix, thank you @vishnuprakaz! |
Contributor
Author
vishnuprakaz
force-pushed
the
variant-string-comparator-fix
branch
from
August 4, 2026 06:26
9449b8e to
198cfa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries on shredded variant string fields can silently miss matching rows.
Metrics bounds for shredded variant strings are merged across row groups with Java's String.compareTo, but Parquet stats and the read-side evaluator order strings by UTF-8 bytes. The two orders disagree for characters outside the basic plane, like emoji: Java sorts them before some regular characters, UTF-8 after. When a shredded string column spans row groups containing both kinds, the merged lower/upper bounds come out inverted and the metrics evaluator can skip files that actually contain matching rows.
The fix switches variant STRING bounds to Comparators.charSequences(), the same comparator the scan path uses. The BINARY branch already used unsignedBytes() and non-variant strings already used charSequences(); variant STRING was the only case falling back to natural ordering. Same class of bug as #16880.
▎ The bug is in 1.10.0 and 1.11.0; backports will follow.