Skip to content

Parquet: Fix variant STRING metrics bounds to use UTF-8 byte order - #17397

Open
vishnuprakaz wants to merge 1 commit into
apache:mainfrom
vishnuprakaz:variant-string-comparator-fix
Open

Parquet: Fix variant STRING metrics bounds to use UTF-8 byte order#17397
vishnuprakaz wants to merge 1 commit into
apache:mainfrom
vishnuprakaz:variant-string-comparator-fix

Conversation

@vishnuprakaz

@vishnuprakaz vishnuprakaz commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Queries on shredded variant string fields can silently miss matching rows.

Metrics bounds for shredded variant strings are merged across row groups with Java's String.compareTo, but Parquet stats and the read-side evaluator order strings by UTF-8 bytes. The two orders disagree for characters outside the basic plane, like emoji: Java sorts them before some regular characters, UTF-8 after. When a shredded string column spans row groups containing both kinds, the merged lower/upper bounds come out inverted and the metrics evaluator can skip files that actually contain matching rows.

The fix switches variant STRING bounds to Comparators.charSequences(), the same comparator the scan path uses. The BINARY branch already used unsignedBytes() and non-variant strings already used charSequences(); variant STRING was the only case falling back to natural ordering. Same class of bug as #16880.

▎ The bug is in 1.10.0 and 1.11.0; backports will follow.

@uros-b

uros-b commented Jul 28, 2026

Copy link
Copy Markdown
Member

Nice fix, thank you @vishnuprakaz!

@vishnuprakaz

Copy link
Copy Markdown
Contributor Author

@nssalian could you please take a look. it's similar to #16880.

I also checked whether iceberg-go is affected it isn't, since Go's native string comparison is already byte order.

@nssalian nssalian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@vishnuprakaz
vishnuprakaz force-pushed the variant-string-comparator-fix branch from 9449b8e to 198cfa8 Compare August 4, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants