[Test] Avoid metadata lease fencing in DataNode unit tests#18284
Open
Caideyipi wants to merge 1 commit into
Open
[Test] Avoid metadata lease fencing in DataNode unit tests#18284Caideyipi wants to merge 1 commit into
Caideyipi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DataNode unit-test JVMs do not receive ConfigNode heartbeats. When a cache-related test class runs for more than the 20-second metadata lease threshold, the singleton
MetadataLeaseManagerfences the local caches and causes unrelated test failures such asTreeViewTest.Configure the DataNode unit-test environment to disable the background metadata lease check. This only changes
src/test/resources; production and integration-test configurations are unaffected. The metadata lease tests keep their coverage because they use independently constructed managers with injected clocks.Setting the test-wide check interval avoids duplicating lease recovery setup across every cache test and also protects future unit tests that use the same guarded singletons.
Verification
git diff --checkThis PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
iotdb-core/datanode/src/test/resources/iotdb-system.properties