Track null value ratio of flushed MemTables#18287
Open
jt2594838 wants to merge 4 commits into
Open
Conversation
hongzhi-gao
approved these changes
Jul 23, 2026
Collaborator
|
Confirmed the aligned-tablet row-failure issue with a regression test. When a row is marked failed in the TSStatus results array, insertAlignedTablet still counted all of its field values in totalValueCount, while null counting also ignored the row status. The new test failed before the fix with expected totalValueCount 2 but actual 4.\n\nPushed fix ec09574, which excludes failed rows from valid-value/null-value statistics and from pointsInserted.\n\nVerification:\n- Target regression test: 1 test passed\n- AbstractMemTablePartialInsertTest: 15 tests passed\n- datanode spotless:check passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Null value statistics
Flush logging and monitoring
Tests
This PR has:
Key changed/added classes