JAMES-4209 Improve S3 data recovery handling + JAMES-4224 entropy 256 -> 128 bits - #3153
Open
chibenwa wants to merge 7 commits into
Open
JAMES-4209 Improve S3 data recovery handling + JAMES-4224 entropy 256 -> 128 bits#3153chibenwa wants to merge 7 commits into
chibenwa wants to merge 7 commits into
Conversation
chibenwa
force-pushed
the
recovery
branch
2 times, most recently
from
September 6, 2026 00:50
04be82a to
b1913fd
Compare
This was referenced Sep 7, 2026
Arsnael
approved these changes
Sep 7, 2026
Arsnael
approved these changes
Sep 8, 2026
Key design decision: - DUPLICATE headers: needed for recovery info unicity - Use of BlobStoreDAO: apply the above AND allow passing metadata Impact: - full scan of the generation needed - Need to explicitly ask to cache headers - Save-in-sequence body-then-header is needed... - 2 object instead of 3 thus limiting dramatically pressure on S3 store metadata - Simplify GC: no side car handling
quantranhong1999
force-pushed
the
recovery
branch
from
September 9, 2026 04:16
bb9f9ac to
4c9d316
Compare
quantranhong1999
approved these changes
Sep 9, 2026
quantranhong1999
left a comment
quantranhong1999
left a comment
Member
There was a problem hiding this comment.
LGTM.
I rebased to solve conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key ideas:
What this achieves: