Skip to content

KAFKA-16158: Cleanup usage of TimestampedBytesStore interface - #23233

Open
gabriellefu wants to merge 3 commits into
apache:trunkfrom
gabriellefu:cleanup
Open

KAFKA-16158: Cleanup usage of TimestampedBytesStore interface#23233
gabriellefu wants to merge 3 commits into
apache:trunkfrom
gabriellefu:cleanup

Conversation

@gabriellefu

Copy link
Copy Markdown
Contributor
  1. KeyValueToTimestampedKeyValueByteStoreAdapter now implements TimestampedBytesStore, fixing the inconsistency where it stored <timestamp><value> data without advertising the interface.
  2. Reordered StateManagerUtil.converterForStore to check the wrapped chain for adapters first, returning identity() for the KV adapter before the isHeadersAware/isTimestamped checks.
  3. Removed the now-redundant StoreQueryUtils.isAdapter() helper and its two call sites (CachingKeyValueStore, StoreQueryUtils.deserializeValue), since WrappedStateStore.isTimestamped() now returns true for the adapter.
  4. Rewrote StateManagerUtilConverterTest to use real store-builder chains instead of mocks, giving genuine round-trip regression coverage for KAFKA-16141 (in-memory retains timestamp 42, persistent-plain uses dummy -1).

@github-actions github-actions Bot added triage PRs from the community streams labels Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streams triage PRs from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant