KAFKA-16158: Cleanup usage of TimestampedBytesStore interface - #23233
Open
gabriellefu wants to merge 3 commits into
Open
KAFKA-16158: Cleanup usage of TimestampedBytesStore interface#23233gabriellefu wants to merge 3 commits into
TimestampedBytesStore interface#23233gabriellefu wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeyValueToTimestampedKeyValueByteStoreAdapternow implementsTimestampedBytesStore, fixing the inconsistency where it stored<timestamp><value>data without advertising the interface.StateManagerUtil.converterForStoreto check the wrapped chain for adapters first, returningidentity()for the KV adapter before theisHeadersAware/isTimestampedchecks.StoreQueryUtils.isAdapter()helper and its two call sites (CachingKeyValueStore,StoreQueryUtils.deserializeValue), sinceWrappedStateStore.isTimestamped()now returnstruefor the adapter.StateManagerUtilConverterTestto use real store-builder chains instead of mocks, giving genuine round-trip regression coverage for KAFKA-16141 (in-memory retains timestamp42, persistent-plain uses dummy-1).